After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577281 - NM shows confusing icon when cable is plugged
NM shows confusing icon when cable is plugged
Status: RESOLVED INVALID
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other All
: Normal trivial
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2009-03-30 09:03 UTC by Paul van Tilburg
Modified: 2010-03-29 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The center icon is the one (5.10 KB, image/png)
2009-03-31 11:50 UTC, Paul van Tilburg
Details

Description Paul van Tilburg 2009-03-30 09:03:34 UTC
Please describe the problem:
I am using NM 0.7.0.99 (Debian unstable) and when I connect a cable and get an address, NM shows an icon where the UTP cable is unplugged, this is confusing!

Steps to reproduce:
1. Make sure nm-applet is running.
2. Connect a cable and wait for DHCP to finish.



Actual results:
NM shows an icon where the cable is unplugged.

Expected results:
NM shows an icon with the UTP cable plugged.

Does this happen every time?
Yes!

Other information:
Comment 1 Dan Williams 2009-03-31 03:33:30 UTC
Could you get a screenshot of the icon that you think is wrong?  You should be able to use Alt+PrintScreen to get one.
Comment 2 Paul van Tilburg 2009-03-31 11:50:30 UTC
Created attachment 131770 [details]
The center icon is the one
Comment 3 Josselin Mouette 2009-05-10 06:39:53 UTC
This icon is shipped in gnome-icon-theme, not in NM itself.
Comment 4 Sven Arvidsson 2009-09-30 16:57:57 UTC
The icon is nm-device-wired, shipped in gnome-icon-theme.

Should this bug be reassign there instead?
Comment 5 Sven Arvidsson 2009-09-30 21:56:43 UTC
As I mentioned in the downstream Debian bug, the extra nm-* icons are symlinks created by icon-naming-utils, probably for some compatibility reason:

        <icon name="network-idle">
            <link>gnome-netstatus-idle</link>
            <link>nm-adhoc</link>
            <link>nm-device-wired</link>
            <link>nm-device-wireless</link>
            <link>connect_established</link>
        </icon>
Comment 6 Josselin Mouette 2009-10-01 07:25:04 UTC
Well, if they weren’t created, there wouldn’t be a nm-device-wired icon at all.

BTW the code you mention is that of the upstream icon-naming-utils, which is even worse since it doesn’t make any difference in NM between different kinds of connection: here you see that wired and wireless are the same icon.

We have a patch for icon-naming-utils in Debian that makes nm-device-wired to network-wired instead, but it is obviously not enough. There has to be a "connected wire" and a "disconnected wire" icons, which look different enough. Currently they don’t exist, so we use the one that is closest to what we need.
Comment 7 Sven Arvidsson 2009-10-01 12:40:13 UTC
(In reply to comment #6)
> Well, if they weren’t created, there wouldn’t be a nm-device-wired icon at all.

network-manager-applet ships with it's own icons, or maybe that wasn't what you meant?
Comment 8 Josselin Mouette 2009-10-01 13:12:12 UTC
(In reply to comment #7)
> network-manager-applet ships with it's own icons, or maybe that wasn't what you
> meant?

These icons are not useful either: in the ones shipped by NM, nm-device-wired is actually a clone of network-idle, which is not representative of the state of the connection; and nm-device-wireless is not shipped.
Comment 9 Sven Arvidsson 2009-10-01 13:27:46 UTC
Well, they're certainly less confusing than the ones used now, from gnome-icon-theme. 

Anyway, the NM icons should be updated (there's discussion about this in bug 504822 but it seems to have stalled) using legacy symlinks to work around this doesn't seem like a good idea.
Comment 10 Josselin Mouette 2009-10-01 13:44:55 UTC
(In reply to comment #9)
> Well, they're certainly less confusing than the ones used now, from
> gnome-icon-theme. 

Oh please… One way or another, nm-device-wired sucks. Arguing about which one is less broken is pointless, we should work on producing an icon that doesn’t suck instead.
Comment 11 Sven Arvidsson 2009-10-01 17:03:08 UTC
This is caused by a patch Debian applies to icon-naming-utils, this bug should probably be closed and handled downstream.
Comment 12 Josselin Mouette 2009-10-01 17:22:51 UTC
Did you actually read my explanations? The situation is *much* worse without that patch. In this case it doesn’t even make a difference between a wired and a wireless connection!
Comment 13 Josselin Mouette 2009-10-01 17:28:01 UTC
Could you please reassign this bug to gnome-icon-theme? What we need is a distinction between e.g. 'network-wired-plugged' (which doesn’t exist currently) and 'network-wired-unplugged' (the current network-wired icon).
Comment 14 Sven Arvidsson 2009-10-01 17:37:08 UTC
Feel free to wontfix the debian bug.

At least on my system, wireless connections are shown with signal strength and
mobile broadband with a cell phone icon. The only place it seems to use the
same icons for wired and wireless are in the network connections settings?

Anyway, removing the nm-* icons from icon-naming-utils would probably be good,
as a change in icons would be shipped with NM, not the icon theme AFAICT.
Comment 15 Lapo Calamandrei 2010-03-29 16:47:37 UTC
Thanks for reporting, but this is clearly not a gnome-icon-theme bug, closing INVALID.
Comment 16 Josselin Mouette 2010-03-29 16:54:53 UTC
(In reply to comment #15)
> Thanks for reporting, but this is clearly not a gnome-icon-theme bug, closing
> INVALID.

Why? There is still no possibility to distinguish between a plugged wire and an unplugged one. As long as there are no icons to do so, users are bound to be confused by the current situation.