After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577236 - missing initialization in xvimagesink
missing initialization in xvimagesink
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.22
Other NetBSD
: Normal major
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-29 22:07 UTC by Matthias Drochner
Modified: 2009-03-30 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matthias Drochner 2009-03-29 22:07:34 UTC 
A missing initialization can cause g_thread_join to be called
with some random argument, leading to an abort() in glib.

--- sys/xvimage/xvimagesink.c.orig      2009-01-13 23:17:00.000000000 +0100
+++ sys/xvimage/xvimagesink.c
@@ -3211,6 +3211,7 @@ gst_xvimagesink_init (GstXvImageSink * x
 
   xvimagesink->synchronous = FALSE;
   xvimagesink->double_buffer = TRUE;
+  xvimagesink->event_thread = NULL;
   xvimagesink->running = FALSE;
   xvimagesink->keep_aspect = FALSE;
   xvimagesink->handle_events = TRUE;
Comment 1 Jan Schmidt 2009-03-29 23:12:46 UTC 
If you're seeing an abort, this isn't the cause - gobject initialises object structures to 0 at allocation, so this extra statement will have no effect.
Comment 2 Matthias Drochner 2009-03-30 12:10:47 UTC 
It seems you are right... There seems to be some rather subtle memory
corruption. I've only seen the crash with totem and its coherence/twisted
UPnP plugin. I'll close the bug.