Created attachment 131391 [details] [review]
use ephy_dot_dir()

Created attachment 131392 [details] [review]
remove files when cancelling

Created attachment 131393 [details] [review]
auto-download and lock-down support

I'll be working on readding the save/cancel/open dialog now. I have studied the mozilla code a bit, and have some ideas about how to implement it with the webkit backend.

The third patch was actually modified a bit to handle cases where define_destination_uri would return FALSE. All three landed now.

Created attachment 131507 [details] [review]
reimplementation of the save as/cancel/${action} dialog

This is basically a port of the original gecko code. We still lack functionality here, because webkitgtk+ doesn't yet have a fully featured WebKitNetworkRequest object.

(In reply to comment #6)
> Created an attachment (id=131507) [edit]
> reimplementation of the save as/cancel/${action} dialog
> 
> This is basically a port of the original gecko code. We still lack
> functionality here, because webkitgtk+ doesn't yet have a fully featured
> WebKitNetworkRequest object.
> 

+	gdk_display = gtk_widget_get_display(priv->window);

Space between function name and (.

+/* These represent actions to be performed after the download is
+ * successfully completed; NONE means no download will happen,
+ * DOWNLOAD is just a way to tell the mime content handler that a file
+ * chooser should be displayed so that the user can select where to
+ * download to, and is usually turned into OPEN_LOCATION after that
+ * happens. OPEN will try to run the default application that handles
+ * that file type.

OK, if I got it right, DOWNLOAD *can't* actually be an action when the download has been finished. It's only used at the beginning, before it starts. If this is so can you clarify it in the comment? Also, does it make sense to have in the switch of update_download_row?

+  parent_window = gtk_widget_get_toplevel (GTK_WIDGET(web_view));

Space between macro name and (.

+  if (!GTK_WIDGET_TOPLEVEL (parent_window)) {
+    parent_window = NULL;
+  }

No braces?


+  action_label = (action == DOWNLOAD_ACTION_OPEN) ? GTK_STOCK_OPEN : STOCK_DOWNLOAD;

You mean action == DOWNLOAD_ACTION_OPEN_LOCATION here? You don't seem to ever set DOWNLOAD_ACTION_OPEN.

*** Bug 583426 has been marked as a duplicate of this bug. ***

Last patch committed. I'll get back to download when NetworkRequest lands.