After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576690 - Display the current branch
Display the current branch
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
git master
Other All
: Normal enhancement
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2009-03-25 09:58 UTC by jessevdk@gmail.com
Modified: 2009-08-28 18:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The current patches serie (1.89 KB, patch)
2009-03-30 13:42 UTC, Guilhèm Bonnefille
none Details | Review

Description jessevdk@gmail.com 2009-03-25 09:58:35 UTC
The name of the current branch is useful:

    * in history view in order to understand the first viewed history, 
    * in commit view in order to ensure on which branch the commit will be made. 

By "current" I mean the base branch for the working tree, the result of the "git checkout" command. 
My first idea is to display this info in the title bar.
Comment 1 Guilhèm Bonnefille 2009-03-30 13:34:47 UTC
I started to work on this feature. I created a branch:
http://github.com/guyou/gitg/tree/display-current-branch-name
Comment 2 Guilhèm Bonnefille 2009-03-30 13:39:25 UTC
Working around this feature, I had to rework the "current_ref" stuff. But this is suspicious (is the previous work never worked?).

Please, can someone double-check my rework?
http://github.com/guyou/gitg/commit/90e241e21a2bc21e9e8df0a359668573f0f5e02d
Comment 3 Guilhèm Bonnefille 2009-03-30 13:42:29 UTC
Created attachment 131702 [details] [review]
The current patches serie

I add my patches series to keep track of the availability of a patch (waiting Gnome's bugzilla add a "pull request" property)
Comment 4 jessevdk@gmail.com 2009-06-23 23:44:15 UTC
I have currently implemented selecting the 'current' branch in the branches combo box. This correctly uses any git revision selection you would have (like invoking gitg <branch-name>). This involved rewriting the load_current_ref (but in a different way than in the proposed patch).

This is different than showing the 'real' current branch (e.g. the checkout branch) which is useful in the commit view. I'm therefore leaving this bug open still so that I don't forget that.
Comment 5 jessevdk@gmail.com 2009-08-28 18:07:31 UTC
This has been fixed now by showing the currently checked-out branch in the window title.