After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576431 - better warning
better warning
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: Disks UI
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2009-03-23 15:11 UTC by Matthias Clasen
Modified: 2009-03-31 21:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch (9.00 KB, patch)
2009-03-27 16:46 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2009-03-23 15:11:32 UTC 
I was trying to delete a partition that was inside an extended partition. The partitions I have are

part1
part2
part3
[extended]
  part4
  part5
  part6

I was going to delete part6. I got a warning dialog that was talking about deleting "partition 7 on the media". This had me slightly confused, because my naming choice didn't make it obvious that part6 is the seventh. I think it would be better to mention the label in the warning dialog, if there is a label.
Comment 1 Matthias Clasen 2009-03-23 15:12:43 UTC 
Similarly, when deleting an extended partition, the warning should make it very clear that all the partitions contained in the extended partition will be deleted too.
Comment 2 Matthias Clasen 2009-03-27 16:46:47 UTC 
Created attachment 131503 [details] [review]
a patch
Comment 3 David Zeuthen (not reading bugmail) 2009-03-31 21:06:27 UTC 
Committed with the following fixes

+        char *type;
+        type = gdu_device_partition_get_type (device);

This causes a compiler warning.

+                        if (strcmp (type, "0x05") == 0) {

Extended partitions can have type 0x05, 0x0f and 0x85. Ideally DeviceKit-disks would have a partition-is-msdos-extended but that is not how it works right now.

http://git.gnome.org/cgit/gnome-disk-utility/commit/?id=1c2c67959f76ac5f0262d7d4dd198540a4055e26