After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575948 - palimpsest: support commandline arguments
palimpsest: support commandline arguments
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: Disks UI
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-disk-utility-maint
Depends on: 577353
Blocks:
 
 
Reported: 2009-03-19 13:05 UTC by Tomas Bzatek
Modified: 2009-03-31 20:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0003-Add-cmdline-options-to-specify-a-device.patch (2.93 KB, patch)
2009-03-27 23:11 UTC, Matthias Clasen
needs-work Details | Review
another try (2.83 KB, patch)
2009-03-31 01:55 UTC, Matthias Clasen
none Details | Review
redo on top of unique application support (6.05 KB, patch)
2009-03-31 03:24 UTC, Matthias Clasen
none Details | Review
return nonzero exit code depending on unique response (6.29 KB, patch)
2009-03-31 14:53 UTC, Matthias Clasen
committed Details | Review

Description Tomas Bzatek 2009-03-19 13:05:25 UTC
Would be great if palimpsest can parse arguments from commandline...

At least we need ability to select specified presentable on startup - e.g. clicking a notification balloon when disk is failing (gnome-settings-daemon extension -- bug 575572).
Comment 1 Matthias Clasen 2009-03-27 23:11:01 UTC
Created attachment 131529 [details] [review]
0003-Add-cmdline-options-to-specify-a-device.patch
Comment 2 David Zeuthen (not reading bugmail) 2009-03-30 14:58:41 UTC
+        { "device-file", 0, 0, G_OPTION_ARG_FILENAME, &device_file, N_("Device file to show"), N_("FILE") },
+        { "presentable", 0, 0, G_OPTION_ARG_STRING, &presentable_id, N_("Presentable to show"), N_("ID") },

Not sure this makes sense. We should instead have

 --show-volume <device>    Volume to show
 --show-drive <device>     Drive to show

In addition we need to handle single-instance properly; suggest to do this via libunique for now.
Comment 3 Matthias Clasen 2009-03-30 20:16:49 UTC
I've filed bug 577353 for the unique application issue.
Comment 4 David Zeuthen (not reading bugmail) 2009-03-30 20:18:24 UTC
Adding it as a dep then.
Comment 5 Matthias Clasen 2009-03-31 01:55:07 UTC
Created attachment 131742 [details] [review]
another try
Comment 6 Matthias Clasen 2009-03-31 03:24:46 UTC
Created attachment 131747 [details] [review]
redo on top of unique application support
Comment 7 Matthias Clasen 2009-03-31 14:53:39 UTC
Created attachment 131780 [details] [review]
return nonzero exit code depending on unique response
Comment 8 David Zeuthen (not reading bugmail) 2009-03-31 20:22:18 UTC
(In reply to comment #7)
> Created an attachment (id=131780) [edit]
> return nonzero exit code depending on unique response
> 

Committed, thanks! I've also nuked the nagging dialog in a subsequent commit.
Comment 9 David Zeuthen (not reading bugmail) 2009-03-31 20:23:22 UTC
Let's deal with the dialog issues in bug 577353.
Comment 10 David Zeuthen (not reading bugmail) 2009-03-31 20:35:41 UTC
Btw, I just added a patch to return a non-zero exit code if the requested drive/volume doesn't exist.