After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575611 - Don't assume GTK_ICON_SIZE_LARGE_TOOLBAR is always 24px
Don't assume GTK_ICON_SIZE_LARGE_TOOLBAR is always 24px
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: GUI
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: Ekiga maintainers
Ekiga maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-16 22:01 UTC by Michael Monreal
Modified: 2013-03-10 12:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Screenshot (18.90 KB, image/png)
2009-03-16 22:03 UTC, Michael Monreal 		Details

Description Michael Monreal 2009-03-16 22:01:45 UTC 
On my notebook (which has a small screen resolution) I use a GTK theme that minimizes screen size. For example, it uses 16x16 icons for toolbar icons. In Ekiga this does not work very well: instead of using the nice 16x16 icons for "pick up" and "hang up", it uses the 24x24 ones and scales them down, making them look blurry.

The problem is this:

  mw->priv->connect_button = gm_connect_button_new (GM_STOCK_PHONE_PICK_UP_24,
                            GM_STOCK_PHONE_HANG_UP_24,
                            GTK_ICON_SIZE_LARGE_TOOLBAR);

Instead of just using a GM_STOCK_PHONE_HANG_UP and let the size be defined by GTK_ICON_SIZE_LARGE_TOOLBAR (in a proper GTK icon lookup function) you assume this icon will always be 24x24 pixels and force-load GM_STOCK_PHONE_HANG_UP_24 directly.
Comment 1 Michael Monreal 2009-03-16 22:03:20 UTC 
Created attachment 130792 [details]
Screenshot
Comment 2 Eugen Dedu 2009-04-12 18:18:04 UTC 
Sorry to ask: can you make a patch?
Comment 3 Michael Monreal 2009-05-05 23:29:21 UTC 
I don't really have time atm (lots of exams) and from what I remember the code/helper functions where scattered around a bit so I would probably break stuff anyway
Comment 4 Damien Sandras 2013-03-10 12:36:12 UTC 
This was fixed in 4.0.

See: image = gtk_image_new_from_icon_name ("phone-hang-up", GTK_ICON_SIZE_LARGE_TOOLBAR);

Sorry for the time it took...