Created attachment 130532 [details] [review]
gnome-media-add-100%-mark.patch

Oh, and a mark for the "base volume" as exported in the sink/sources would be good too, if it differs from PA_VOLUME_NORM and PA_VOLUME_MUTED.

(In reply to comment #2)
> Oh, and a mark for the "base volume" as exported in the sink/sources would be
> good too, if it differs from PA_VOLUME_NORM and PA_VOLUME_MUTED.

We don't really have that much space for this though. And it's not very good UI-wise either as the marks are sticky.

commit 265a129527b2346f7d971e01811970b4cb9157e9
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu May 7 15:52:24 2009 +0100

    Bug 574312 – Add mark at 100% for inputs
    
    Inputs that support dB go all the way up to 150%, so add a mark
    for 100%.

Bastien, if you only want to show one marker then please show base_volume instead of 100% if possible and if different from PA_VOLUME_MUTED.

Something like this would be good:

if (base_volume > PA_VOLUME_MUTED && base_volume < PA_VOLUME_NORM)
   add_marker(base_volume);
else if (amplified)
   add_marker(100%);

Oh, and ideally for both playback and recording, even if you don't extend the scale to 150% for playback.

reopening

As discussed on IRC it might make sense not to expose the base volume as markers but by means of colors in some way. 

Here are my suggestion:

A) if decibel volumes are supported both for sinks and for sources the volume range should be extended to 150% or so. (We already have that for sources, but I think this should be allowed for sinks, too. It is useful if you play some movies on unamplified speakers and has been requested many times on the the PA IRC channel, PA ML)

B) If decibel volumes are supported and base_volume is > MUTED and < NORM, then the part of the slider between MUTED and base_volume should be colored green. The part of the slider between base_volume and NORM should be colored yellow. And the part > NORM should be colored red.

C) If decibel volumes are supported and base_volumes equals MUTED or NORM the part between MUTED and NORM should be colored green, and everything > NORM should be red. No part shall be yellow.

D) If no decibel volumes are supported, the range cannot be extended, and hence is limited to MUTED..NORM. 

E) If no decibel volumes are supported and if base_volume is > MUTED and < NORM, the part < base_volume shall be colored green, the part > base_volume shall be colored yellow. No part shall be red.

F) If no decibel volumes are supported and if base_volume equals MUTED or NORM the part entire slider should be green.

I'd assume that the coloring would be implemented as smooth gradient. If that's the case then in cases E and F it might be an idea to start the gradient to red at the end of the slider, but not actually become fully red, because the slider ends at NORM.

File a separate bug please. I'll make the changes as described above to mark the "base volume" instead of 100% when a source is amplified, but that has nothing to do with markers anymore.

(In reply to comment #7)
> File a separate bug please. I'll make the changes as described above to mark
> the "base volume" instead of 100% when a source is amplified, but that has
> nothing to do with markers anymore.

Done, see bug 582516

commit 4b0c56e4c7771c1560f3a1b0facf61680231cea8
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu May 14 15:30:16 2009 +0100

    Bug 574312 – Add mark for base volume instead of 100%
    
    When the base volume is different from 100% volume, show that
    in the source volume bar.