After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573332 - Allow annotation of enums as bitfields
Allow annotation of enums as bitfields
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-02-26 23:40 UTC by Andreas Rottmann
Modified: 2015-02-07 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow annotation of enums as bitfields (5.39 KB, patch)
2009-02-26 23:41 UTC, Andreas Rottmann
reviewed Details | Review
Introduce documentation-block options (2.31 KB, patch)
2009-03-04 15:05 UTC, Andreas Rottmann
accepted-commit_now Details | Review
Bug 573332 - Allow annotation of enums as bitfields (4.30 KB, patch)
2009-03-04 15:07 UTC, Andreas Rottmann
accepted-commit_now Details | Review

Description Andreas Rottmann 2009-02-26 23:40:56 UTC
Useful for cases where the scanner heuristic fails (e.g. if people don't use the '<<' bitshift
operator).
Comment 1 Andreas Rottmann 2009-02-26 23:41:01 UTC
Created attachment 129619 [details] [review]
Allow annotation of enums as bitfields

Add support for a `(type bitfield)' annotation for enums.

Signed-off-by: Andreas Rottmann <a.rottmann@gmx.at>
Comment 2 Colin Walters 2009-03-03 18:33:29 UTC
I like the annotation style, but will it confuse gtk-doc?

Can you change the hardcoded 'bitfield' string to be OPT_BITFIELD like the other options above?

Also can you split it into two commits?  One for the new doc style, and one for the change to use bitfields.
Comment 3 Andreas Rottmann 2009-03-04 15:05:16 UTC
Created attachment 130021 [details] [review]
Introduce documentation-block options

Allow a documentation block to have options, e.g.:

/*
 * SomeType: (OPT-NAME VALUE) ...
 */

Signed-off-by: Andreas Rottmann <a.rottmann@gmx.at>
Comment 4 Andreas Rottmann 2009-03-04 15:07:01 UTC
Created attachment 130022 [details] [review]
Bug 573332 - Allow annotation of enums as bitfields

Add support for a `(type bitfield)' annotation for enums.

Signed-off-by: Andreas Rottmann <a.rottmann@gmx.at>
Comment 5 Andreas Rottmann 2009-03-04 15:24:52 UTC
(In reply to comment #2)
> I like the annotation style, but will it confuse gtk-doc?
> 
I haven't checked yet, but maybe gtk-doc indeed needs to be tweaked to understand/ignore the options.

> Can you change the hardcoded 'bitfield' string to be OPT_BITFIELD like the
> other options above?
> 
Done.

> Also can you split it into two commits?  One for the new doc style, and one for
> the change to use bitfields.
> 
Done.

Comment 6 André Klapper 2015-02-07 16:55:30 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]