GNOME Bugzilla – Bug 573303
[testing required] Support text attribute and spelling error notification in FF
Last modified: 2009-03-10 14:25:48 UTC
Firefox 3.1 now has support for text attributes: http://www.marcozehe.de/2009/02/16/nvda-06p3-released-quite-some-news-for-mozilla-users/. I tested Insert+f with Orca and noticed a lot of junk being output. Here's a snippet of a debug log: readCharAttributes: default text attributes: text-position:middle; font-family:"Bitstream Vera Sans","Luxi Sans","Lucida Grande","Trebuchet MS",helvetica,verdana,arial,sans-serif; color:rgb(51, 51, 51); font-weight:400; background-color:rgb(236, 236, 236); font-size:16px; font-style:normal SPEECH OUTPUT: 'size 16 pixels' SPEECH OUTPUT: 'family name "Bitstream Vera Sans","Luxi Sans","Lucida Grande","Trebuchet MS",helvetica,verdana,arial,sans-serif' We may need to work with the Gecko folks to determine how they intended the "font-family" be interpreted. I'm going to guess *maybe* it's a list of fonts with fallbacks and maybe we should only present the first one. But, Gecko certainly seems to mean the "extended" form of a family rather than a single family. In addition, for what might be a separate enhancement, we should also present things presented as inline spelling mistakes if the user arrows across one of those things. The reason I group it here is that I wonder if we want some sort of feature that will automatically announce text attribute changes (including spelling mistakes) as you arrow across things. Again, that might be a whole other feature request.
(In reply to comment #0) > font-family:"Bitstream Vera Sans","Luxi Sans","Lucida Grande","Trebuchet > MS",helvetica,verdana,arial,sans-serif; color:rgb(51, 51, 51); font-weight:400; > background-color:rgb(236, 236, 236); font-size:16px; font-style:normal ... > We may need to work with the Gecko folks to determine how they intended the > "font-family" be interpreted. I'm going to guess *maybe* it's a list of fonts > with fallbacks and maybe we should only present the first one. From http://www.w3.org/TR/CSS2/fonts.html#font-family-prop, it looks as though it is a list of prioritized fonts names and we probably should take the first one, stripping it of any quotes that might be around it (the quotes are for font family names with spaces in them).
Created attachment 129672 [details] [review] Rev 1 This patch seems to resolve the problem and is compatible with GTK+. Pylints to a 10.0. Manually tested with gedit, OOo, Firefox 3.1b2. Need to regression test.