Still responds to state changes from NetworkManager, but I found two problems:

  1) We don't check the current network state on startup.  We use whatever
     the online state was when we last exited.  This is fine if we chose to
     go offline, but if we were -forced- offline we should try to reconnect
     again.  Currently we don't distinguish.

  2) Unselecting "Enable Wireless" from NetworkManager emits a StateChanged
     signal with an argument value of NM_STATE_DISCONNECTED.  We detect that
     and correctly go into a "forced offline" state, and then automatically
     reconnect when we're back on a wireless network.

     Unselecting "Enable Networking" from NetworkManager, however, emits a
     StateChanged signal with an argument value of NM_STATE_ASLEEP.  We're
     not checking for that and we should.  For our purposes we should
     handle it the same as NM_STATE_DISCONNECTED.

Think I'll deal with (1) as a separate enhancement and just tackle (2) here.

Got it working on the kill-bonobo branch.  I'll tackle trunk next.

Created attachment 129421 [details] [review]
Unbork trunk

So trunk was pretty borked, and it's probably my fault.  This made it work again for me, and it also now correctly handles NM_STATE_ASLEEP.

I can confirm that the patch fixes the issue

Patch committed to trunk (revision 37320).