Bug 572705 – crash in Rhythmbox Music Player: Downloading podcasts. M...

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 572705 - crash in Rhythmbox Music Player: Downloading podcasts. M...


Summary:	crash in Rhythmbox Music Player: Downloading podcasts. M...


Status:	RESOLVED FIXED

Product:	totem-pl-parser
Classification:	Core
Component:	General
Version:	unspecified
Hardware:	Other All

Importance:	High critical
Target Milestone:	---
Assigned To:	totem-pl-parser-maint
QA Contact:	totem-pl-parser-maint

URL:
Whiteboard:

Duplicates:	597265 (view as bug list)
Depends on:
Blocks:

Reported:	2009-02-22 02:33 UTC by mattmcadoo
Modified:	2009-12-04 15:20 UTC

See Also:
GNOME target:	---
GNOME version:	2.23/2.24

Attachments
Make totem-pl-parser reentrant (16.99 KB, patch) 2009-10-04 01:50 UTC, Matt Kraai	none	Details \| Review
Make thread-safe. (27.67 KB, patch) 2009-10-20 03:32 UTC, Matt Kraai	none	Details \| Review
Make totem-pl-parser thread-safe (29.00 KB, patch) 2009-12-03 08:55 UTC, Matt Kraai	none	Details \| Review

Description mattmcadoo 2009-02-22 02:33:16 UTC

Version: 0.11.6

What were you doing when the application crashed?
Downloading podcasts.  Main one was Freedomain Radio, the complete series.


Distribution: Gentoo Base System release 2.0.0
Gnome Release: 2.24.3 2009-01-26 (Gentoo)
BugBuddy Version: 2.24.2

System: Linux 2.6.26-hardened-r1 #2 SMP PREEMPT Thu Sep 4 11:18:04 CDT 2008 i686
X Vendor: The X.Org Foundation
X Vendor Release: 10503000
Selinux: Enforcing
Accessibility: Disabled
GTK+ Theme: Unity
Icon Theme: gnome-alternative

Memory status: size: 149082112 vsize: 149082112 resident: 47378432 share: 21147648 rss: 47378432 rss_rlim: 18446744073709551615
CPU usage: start_time: 1235244700 rtime: 111623 utime: 98502 stime: 13121 cutime:4 cstime: 146 timeout: 0 it_real_value: 0 frequency: 100

Backtrace was generated from '/usr/bin/rhythmbox'

[Thread debugging using libthread_db enabled]
[New Thread 0xb666faa0 (LWP 21740)]
[New Thread 0xb08f7b90 (LWP 27648)]
[New Thread 0xb38fdb90 (LWP 25150)]
[New Thread 0xb00f6b90 (LWP 21804)]
0xb8048422 in __kernel_vsyscall ()

+ Trace 212772

Thread 2 (Thread 0xb08f7b90 (LWP 27648))

#0 __kernel_vsyscall
#1 waitpid
from /lib/libpthread.so.0
#2 IA__g_spawn_sync
at gspawn.c line 382
#3 IA__g_spawn_command_line_sync
at gspawn.c line 694
#4 run_bug_buddy
at gnome-breakpad.cc line 223
#5 check_if_gdb
at gnome-breakpad.cc line 292
#6 bugbuddy_segv_handle
at gnome-breakpad.cc line 84
#7 <signal handler called>
#8 lexer_get_token
#9 xml_parser_get_node_internal
at xmlparser.c line 242
#10 xml_parser_get_node_internal
at xmlparser.c line 334
#11 xml_parser_get_node_internal
at xmlparser.c line 334
#12 xml_parser_get_node_internal
at xmlparser.c line 334
#13 xml_parser_get_node_internal
at xmlparser.c line 334
#14 xml_parser_build_tree_with_options
at xmlparser.c line 628
#15 totem_pl_parser_add_rss
at totem-pl-parser-podcast.c line 247
#16 totem_pl_parser_parse_internal
at totem-pl-parser.c line 1534
#17 totem_pl_parser_parse_with_base
at totem-pl-parser.c line 1633
#18 totem_pl_parser_parse
at totem-pl-parser.c line 1657
#19 rb_podcast_parse_load_feed
at rb-podcast-parse.c line 196
#20 rb_podcast_manager_thread_parse_feed
at rb-podcast-manager.c line 972
#21 g_thread_create_proxy
at gthread.c line 635
#22 start_thread
at pthread_create.c line 297
#23 clone
at ../sysdeps/unix/sysv/linux/i386/clone.S line 59
#24 ??

Comment 1 Jonathan Matthew 2009-02-22 03:42:23 UTC

Seems to have crashed trying to parse http://completeliberty.libsyn.com/rss.  That feed works correctly with svn trunk of rhythmbox and totem-pl-parser, however.

Comment 2 Matt Kraai 2009-09-22 13:38:01 UTC

Given the backtrace, I suspect this is the same problem as in Debian bug 547683 (cf. http://bugs.debian.org/547683).

Comment 3 Matt Kraai 2009-10-04 01:50:50 UTC

Created attachment 144695 [details] [review]
Make totem-pl-parser reentrant

This patch makes totem-pl-parser reentrant, which has prevented Rhythmbox from crashing on my system.

Comment 4 Bastien Nocera 2009-10-04 23:30:27 UTC

*** Bug 597265 has been marked as a duplicate of this bug. ***

Comment 5 Bastien Nocera 2009-10-04 23:32:12 UTC

Moving to totem-pl-parser.

Could you send this patch, once updated, to xine upstream? xine-lib is where this function lives.

Comment 6 Matt Kraai 2009-10-05 03:40:04 UTC

(In reply to comment #5)
> Moving to totem-pl-parser.
> 
> Could you send this patch, once updated, to xine upstream? xine-lib is where
> this function lives.

Done.  See http://bugs.xine-project.org/show_bug.cgi?id=281.

Comment 7 Bastien Nocera 2009-10-16 15:57:53 UTC

Now that the patch has been committed upstream, any chance you could update your patch here? Thanks for the work...

Comment 8 Matt Kraai 2009-10-20 03:32:14 UTC

Created attachment 145825 [details] [review]
Make thread-safe.

(In reply to comment #7)
> Now that the patch has been committed upstream, any chance you could update
> your patch here? Thanks for the work...

Unfortunately, the upstream patch was against xine-lib's 1.1 branch, rather than the 1.2 branch than totem-pl-parser appears to have pulled from.  I've submitted an updated patch which, if applied, should result in this patch to totem-pl-parser.

Comment 9 Matt Kraai 2009-12-03 08:55:51 UTC

Created attachment 148987 [details] [review]
Make totem-pl-parser thread-safe

Upstream performed their own merge of the thread-safety changes into the 1.2 branch, so I regenerated the patch based on the result of their merge.  I think it's ready to go in now.

Comment 10 Bastien Nocera 2009-12-04 15:20:03 UTC

Fixed in gnome-2-28, thanks!

commit 9cec1603cbd7991ef1eb23679acc74fdfce36f12
Author: Matt Kraai <kraai@ftbfs.org>
Date:   Thu Dec 3 00:48:55 2009 -0800

    Make totem-pl-parser thread-safe
    
    https://bugzilla.gnome.org/show_bug.cgi?id=572705