After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572238 - Remove deprecated Glib symbols
Remove deprecated Glib symbols
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Blocks: 560423
 
 
Reported: 2009-02-18 04:18 UTC by André Klapper
Modified: 2009-06-10 22:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Removed depricated Symbols (806 bytes, patch)
2009-04-02 00:10 UTC, Kyle Pelton 		none Details | Review
Removed depricated Symbols (805 bytes, patch)
2009-04-02 00:11 UTC, Kyle Pelton 		none Details | Review
Fixed patch (834 bytes, patch)
2009-04-07 20:59 UTC, Kyle Pelton 		committed Details | Review

Description André Klapper 2009-02-18 04:18:40 UTC 
http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib

./src/common/plugin.c:
   return g_io_channel_read (source, buf, *len, len);
./src/common/server.c:
   if (g_io_channel_read (source, &buf[i], 1, &len) != G_IO_ERROR_NONE)

http://library.gnome.org/devel/glib/unstable/glib-IO-Channels.html#g-io-channel-read
Comment 1 Kyle Pelton 2009-04-02 00:10:09 UTC 
Created attachment 131879 [details] [review]
Removed depricated Symbols
Comment 2 Kyle Pelton 2009-04-02 00:11:02 UTC 
Created attachment 131880 [details] [review]
Removed depricated Symbols
Comment 3 Christian Persch 2009-04-02 12:10:11 UTC 
+	        if (g_io_channel_read_chars(source, &buf[i], 1, &len, NULL) != G_IO_ERROR_NORMAL)

I think this should be G_IO_STATUS_NORMAL instead.
Comment 4 Kyle Pelton 2009-04-07 20:59:26 UTC 
Created attachment 132295 [details] [review]
Fixed patch

Your right, oops
Comment 5 Christian Persch 2009-04-12 18:03:47 UTC 
Committed to svn trunk after 2.26.1 release. Thanks for the patch!
Comment 6 Tobias Mueller 2009-04-13 19:48:21 UTC 
I assume, that patch has been committed and I am thus marking the patch as such :)