GNOME Bugzilla – Bug 571754
Get rid of deprecated Bonobo
Last modified: 2009-07-27 21:06:19 UTC
libbonobo and libbonoboui are deprecated as per http://live.gnome.org/TwoPointTwentyfive/Platform and hence the dependency should be completely removed. See for example http://www.ibm.com/developerworks/linux/library/l-dbus.html or http://www.mail-archive.com/gnome-devel-list@gnome.org/msg00997.html . ./gnome-media/cddb-slave2/cddb-track-editor.c:static BonoboObjectClass *parent_class = NULL; ./gnome-media/cddb-slave2/cddb-track-editor.c: BonoboObject parent; ./gnome-media/cddb-slave2/cddb-track-editor.c: BonoboObjectClass parent_class; ./gnome-media/cddb-slave2/cddb-track-editor.c:static BonoboObject * ./gnome-media/cddb-slave2/main.c:static BonoboObject * ./gnome-media/cddb-slave2/cddb-slave.c:static BonoboObjectClass *parent_class = NULL; ./gnome-media/cddb-slave2/cddb-slave.h: BonoboObject parent; ./gnome-media/cddb-slave2/cddb-slave.h: BonoboObjectClass parent_class; ./gnome-media/cddb-slave2/cddb-track-editor.c:#include <libbonoboui.h> ./gnome-media/cddb-slave2/main.c:#include <libbonobo.h> ...and configure.ac of course.
Andre, it's only in cddb-slave, which is just there because of history. The dependency is optionnal, afaik. I think we can consider this as WONTFIX. Or we should just remove CDDB-Slave once for all (I don't really see the point, but I really don't care..)
Actually it's not only cddb-slave after also grep'ing for "#include <bonobo": ./gnome-media/gnome-cd/access/cddisplayaccessible.c:#include <bonobo.h> ./gnome-media/gnome-cd/gnome-cd.c:#include <bonobo.h> ./gnome-media/gnome-cd/callbacks.c:#include <bonobo/bonobo-exception.h> ./gnome-media/gnome-cd/callbacks.c:#include <bonobo/bonobo-control.h> ./gnome-media/gnome-cd/callbacks.c:#include <bonobo/bonobo-widget.h> ./gnome-media/gnome-cd/callbacks.c:#include <bonobo-activation/bonobo-activation.h> ./gnome-media/gnome-cd/cddb.c:#include <bonobo/bonobo-listener.h> ./gnome-media/gstreamer-properties/pipeline-constants.c:#include <bonobo/bonobo-i18n.h> ./gnome-media/cddb-slave2/cddb-slave2-query.c:#include <bonobo/bonobo-main.h> ./gnome-media/cddb-slave2/cddb-slave-client.h:#include <bonobo/bonobo-listener.h> ./gnome-media/cddb-slave2/cddb-track-editor.c:#include <bonobo-activation/bonobo-activation.h> ./gnome-media/cddb-slave2/main.c:#include <bonobo-activation/bonobo-activation.h> ./gnome-media/cddb-slave2/cddb-slave.c:#include <bonobo/bonobo-object.h> ./gnome-media/cddb-slave2/cddb-slave.c:#include <bonobo/bonobo-event-source.h> ./gnome-media/cddb-slave2/cddb-slave.c:#include <bonobo/bonobo-main.h> ./gnome-media/cddb-slave2/cddb-slave.c:#include <bonobo/bonobo-arg.h> ./gnome-media/cddb-slave2/cddb-slave.c:#include <bonobo/bonobo-exception.h> ./gnome-media/cddb-slave2/cddb-slave-client.c:#include <bonobo-activation/bonobo-activation.h> ./gnome-media/cddb-slave2/cddb-slave-client.c:#include <bonobo/bonobo-listener.h> ./gnome-media/cddb-slave2/cddb-slave-client.c:#include <bonobo/bonobo-object.h> ./gnome-media/cddb-slave2/cddb-slave-client.c:#include <bonobo/bonobo-exception.h> ./gnome-media/cddb-slave2/cddb-slave.h:#include <bonobo/bonobo-xobject.h> ./gnome-media/cddb-slave2/cddb-slave.h:#include <bonobo/bonobo-event-source.h>
Ok, so the one to fix is: gstreamer-properties/pipeline-constants.c: #include <bonobo/bonobo-i18n.h>
(In reply to comment #3) > Ok, so the one to fix is: > gstreamer-properties/pipeline-constants.c: > #include <bonobo/bonobo-i18n.h> Seems like this is already covered by the patch in 567310 that awaits review. :-)
for the records, active gnome-media component are bonobo-free since 567310 has been closed.
commit ce6efc01b852c92db7f783f538b42f82065c11ed Author: Marc-André Lureau <marcandre.lureau@gmail.com> Date: Mon Jul 27 21:56:29 2009 +0300 Remove vumeter, cddb, and gnome-cd