After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571646 - [FAQ] indenting rules suggested are not up to date
[FAQ] indenting rules suggested are not up to date
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: www
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-13 16:19 UTC by Martin Samuelsson
Modified: 2009-02-14 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Martin Samuelsson 2009-02-13 16:19:58 UTC 
The following page states that running indent with a line length of 100 characters would make the source apply to current coding standard.

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/faq/html/chapter-developing.html

However, the git commit hook makes commits with lines longer than 80 characters fail.

I suggest to update the FAQ from:

indent -br -bad -cbi0 -cli2 -bls -l100 -ut -ce

to:

indent -br -bad -cbi0 -cli2 -bls -l80 -ut -ce

(I don't know if the command is completely correct except for that)
Comment 1 Tim-Philipp Müller 2009-02-14 13:41:48 UTC 
Well spotted, thanks for the bug report. Should be fixed now, among a few other things:

commit 1c716ae4074bac102c5878770c2a1138c8810773
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sat Feb 14 13:35:48 2009 +0000

    FAQ: update for git and miscellaneous small fixes and additions
    
    Replace all mentions of CVS with git. Add link to gst-uninstalled script in cgit and to SubmittingPatches page in wiki. Fix some typos. Update indenting rules to what we actually use (#571646).