After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571475 - String problem
String problem
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnome-sudoku
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-12 14:56 UTC by Gabor Kelemen
Modified: 2009-05-12 02:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
furture cleanup (1.50 KB, patch)
2009-05-08 03:14 UTC, Jesse Zhang
committed Details | Review

Description Gabor Kelemen 2009-02-12 14:56:24 UTC
#: ../gnome-sudoku/src/lib/saver.py:107
#, python-format
msgid "Sudoku is unable to created data folder %(path)s."

- should be "create". It may be worth changing "is" to "was", so that the message would be the same as this:

#: ../gnome-sudoku/src/lib/saver.py:114
#, python-format
msgid "Sudoku was unable to create data folder %(path)s."
Comment 1 Christian Persch 2009-02-12 15:02:25 UTC
-> gnome-sudoku
Comment 2 Jesse Zhang 2009-05-08 02:54:10 UTC
Is 'was' better than 'is' in this case? (tongue twister! :)

diff --git a/gnome-sudoku/src/lib/saver.py b/gnome-sudoku/src/lib/saver.py
index 0dd550e..e261148 100644
--- a/gnome-sudoku/src/lib/saver.py
+++ b/gnome-sudoku/src/lib/saver.py
@@ -120,7 +120,7 @@ class SudokuTracker:
                         title=_('No Space'),
                         label=_('No space left on disk'),
                         message_type=gtk.MESSAGE_ERROR,
-                        sublabel=_('Sudoku is unable to created data folder %(path)s.')%locals() +\
+                        sublabel=_('Sudoku was unable to create data folder %(path)s.')%locals() +\
                                  _('There is no disk space left!')
                         )
                 else:
Comment 3 Jesse Zhang 2009-05-08 03:14:36 UTC
Created attachment 134239 [details] [review]
furture cleanup

Besides the 'created' typo, I would suggest to keep aligned with the rest of saver.py. i.e. 'sublabel' doesn't contain the word 'Sudoku' and there is a newline between the message and the error.
Comment 4 Jesse Zhang 2009-05-12 02:16:41 UTC
Committed to trunk:
http://git.gnome.org/cgit/gnome-games/commit/?id=784cccfa6cc059afe9cb8c7f040ea9da2317287b.

My first commit, and it turns out I did make a mistake finally, I forgot to mention this bug number in the commit message.