After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571068 - gvc preferences code cleanup
gvc preferences code cleanup
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gst-mixer
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks: 571106
 
 
Reported: 2009-02-09 18:43 UTC by Brian Cameron
Modified: 2009-03-04 21:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
patch (2.06 KB, patch)
2009-02-09 18:44 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2009-02-09 18:43:56 UTC 
The attached patch cleans up the gvc preferences.c file a little bit.  It basically adds the pagenum directly to the gtk_list_store and then avoids 
having to look up the pagenum in the sort_by_page_num function.  This makes the
code simpler and should be a bit more efficient since string comparisons aren't needed to determine the page number.
Comment 1 Brian Cameron 2009-02-09 18:44:33 UTC 
Created attachment 128314 [details] [review]
patch
Comment 2 Brian Cameron 2009-02-09 20:02:50 UTC 
Note this patch was written by Garrett D'Amore <garrett.damore@sun.com>
Comment 3 Brian Cameron 2009-03-04 21:32:38 UTC 
Fixed in SVN head.