GNOME Bugzilla – Bug 571015
libprintbackend-cups has unlocalized strings
Last modified: 2009-02-10 17:36:49 UTC
When use cups, some of print options are not localized. I'd like to update cups_option_translations[] and cups_choice_translations[] for ppd strings. I'm attaching the patch.
Created attachment 128269 [details] [review] Patch for modules/printbackends/cups/gtkprintbackendcups.c Attached the patch.
Looks good to me. Please commit, if you can, otherwise I will at some point.
Created attachment 128271 [details] Screenshot Attached the screenshot.
Thanks for your review. I committed the patch. 2009-02-09 Takao Fujiwara <takao.fujiwara@sun.com> Bug 571015 libprintbackend-cups has unlocalized strings Reviewed by Matthias Clasen <mclasen@redhat.com> * modules/printbackends/cups/gtkprintbackendcups.c (handle_option): Add translatable strings from ppd files.
2009-02-09 klockan 06:54 skrev Takao Fujiwara - Tokyo S/W Center: > I added 10 msgids to gtk+. > http://bugzilla.gnome.org/show_bug.cgi?id=571015 > [snip] > #: ../modules/printbackends/cups/gtkprintbackendcups.c:2192 > msgid "Miscellaneous" > msgstr "" This string needs context, e.g. msgctxt "printer-settings".
I added the translator comment with the request from gnome-i18n@gnome.org. @@ -2189,6 +2189,8 @@ static const struct { const char *name; const char *translation; } cups_group_translations[] = { +/* Translators: "Miscellaneous" is the label for a button, that opens + up an extra panel of settings in a print dialog. */ { "Miscellaneous", N_("Miscellaneous") }, };