After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571002 - URL linking also selects trailing dot.
URL linking also selects trailing dot.
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: gnome-2-28
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-02-08 22:54 UTC by C de-Avillez
Modified: 2009-03-26 18:51 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
g-t 2.26.0 screenshot (31.36 KB, image/png)
2009-03-26 16:41 UTC, C de-Avillez
Details

Description C de-Avillez 2009-02-08 22:54:02 UTC
For example:

$ echo http://test.url/thisHasADot.

The traling dot is included in the URL, causing 404s.

This did not happen on 2.22.

Original Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/326975
Comment 1 C de-Avillez 2009-02-08 23:07:44 UTC
Correction: this did not happen in gnome-terminal 2.24.1.
Comment 2 Christian Persch 2009-03-02 17:44:59 UTC
Dots are valid in URIs, so why exactly should they be excluded from the matching?
Comment 3 C de-Avillez 2009-03-18 22:56:16 UTC
Although dots are valid in URIs, it is extremely uncommon to have URIs terminated in a dot (like "http://place.com/stuff.", as opposed to "http://place.com/ustff.done").

It is this termination dot that causes the problems.
Comment 4 C de-Avillez 2009-03-26 14:17:36 UTC
By the way, it is interesting to note that b.g.o. itself does not underline the trailing dot.
Comment 5 Behdad Esfahbod 2009-03-26 16:09:36 UTC
Can't reproduce.  Is this still happening?
Comment 6 C de-Avillez 2009-03-26 16:41:02 UTC
Created attachment 131445 [details]
g-t 2.26.0 screenshot
Comment 7 C de-Avillez 2009-03-26 16:41:28 UTC
Yes. Did you try it on trunk?
Comment 8 Behdad Esfahbod 2009-03-26 18:49:51 UTC
Ok, I see.  This was introduced by this patch:
http://svn.gnome.org/viewvc/gnome-terminal/trunk/src/terminal-screen.c?r1=3259&r2=3258&pathrev=3259
Comment 9 Behdad Esfahbod 2009-03-26 18:51:25 UTC
Committed revision 3396.