GNOME Bugzilla – Bug 570551
(ARIA) UIUC Number Guessing Game Alert Dialog not presented when it appears
Last modified: 2009-02-24 21:47:53 UTC
1) Go to http://test.cita.uiuc.edu/aria/alertdialog/alertdialog1.php 2) Enter a number and press return 3) An "Alert Box" dialog appears. Orca doesn't automatically present the contents. NOTE: You can arrow to the contents and Orca will present them.
This one seems nicer to work with than the Yahoo/YUI alert - we at least get an alert box where the "Close" button is part of the hierarchy. In addition, this particular example gives focus: to the alert item, making it even easier for us to figure something out.
Created attachment 128583 [details] [review] First pass Here's a first pass at a fix. It does these things: 1) Creates a new _getSpeechForAlert method for Gecko's speech generator that expands the EOC's for an alert if it can (nice idea, Joanie!). 2) Treats the ROLE_ALERT role specially in Gecko's script.py:onFocus. What it does is put the caret context where we'd like it, but makes sure the script logic for handling focus sees that a ROLE_ALERT got focus. Without that, the code falls through to the code that stuffs the focus *and* caret to the first caret context inside the alert, making us miss that the ROLE_ALERT got focus. It seems to work OK, though I'm noticing indeterminate/inconsistent behavior when arrowing around the alert when it first pops up. At best, I can arrow left once and then arrow right and go through the alert. At worst, I can't arrow at all. I'll play some more...
I'm still messing with caret nav. I'll look at the arrowing issue. (I have a patch I'm regression testing which might address it.)
I have another patch and regression test coming up.
Created attachment 128594 [details] [review] Rev 2 along with a new regression test This new patch does things slightly differently, and should hopefully be somewhat insensitive to the caret nav code that Joanie is making. There are a couple oddities I'm seeing, though, but I don't think they are related to this bug and/or patch: 1) The expandEOCs call isn't putting spaces where I might expect them. In particular, we're getting "Alert Box12..." and not "Alert Box 12..." But, we also do everything we can to get rid of extra spaces. So, I might try something a little different in the new speech generator method. 2) When dismissing the dialog, I'm noticing that the braille cursor isn't going back to the text box. Instead, it's not being displayed at all. If I type enough to make sure the caret moves, though, the braille cursor ends up jumping there. This might be something that will be sensitive to Joanie's caret work. Full regression tests running now as a sanity check...
(In reply to comment #5) > Full regression tests running now as a sanity check... This doesn't introduce any new issues to the regression tests and it pylints well.
Then I say go ahead and check it in. I'm still struggling with getting mine right.
(In reply to comment #7) > Then I say go ahead and check it in. I'm still struggling with getting mine > right. Okie dokie! Committed to trunk and gnome-2-24. The minor nits can wait.
Closing. Weĺl open new bugs if people run across them.