After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570550 - (ARIA) UIUC Number Guessing Game Alert not presented when it changes
(ARIA) UIUC Number Guessing Game Alert not presented when it changes
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other opensolaris
: Normal normal
: 2.26.0
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-02-04 21:33 UTC by Willie Walker
Modified: 2009-03-10 14:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Rev 1 (626 bytes, patch)
2009-02-25 19:44 UTC, Willie Walker
committed Details | Review
Regression test that has bad behavior (2.17 KB, patch)
2009-02-27 19:03 UTC, Willie Walker
needs-work Details | Review

Description Willie Walker 2009-02-04 21:33:29 UTC
1) Go to http://test.cita.uiuc.edu/aria/alert/alert1.php.
2) Enter a number and press return
3) The text below the guess area is an alert that is updated.  We don't present it.

Note that the text doesn't get focus, so I'm not sure what we should do here (e.g., speak, but not braille?)
Comment 1 Willie Walker 2009-02-24 21:10:48 UTC
(In reply to comment #0)
> Note that the text doesn't get focus, so I'm not sure what we should do here
> (e.g., speak, but not braille?)

In talking with Mike, we speak this but don't braille it.  We will eventually braille it if we allow for transient (i.e., timed out) braille messages. 

Comment 2 Willie Walker 2009-02-24 22:36:48 UTC
In looking at some specific events, we get these from the alert when the change is made:

object:text-changed:delete(0, 12, Make a guess)
	source: [alert | ]
	application: [application | Firefox]
object:text-changed:insert(0, 26, 12 is not between 1 and 10)
	source: [alert | ]
	application: [application | Firefox]

We could potentially just speak the inserted text in the onTextInserted method if we see the event source is ROLE_ALERT.
Comment 3 Willie Walker 2009-02-25 19:44:26 UTC
Created attachment 129510 [details] [review]
Rev 1

This patch seems to solve the problem well.  Pylints.  Not regression tested.
Comment 4 Willie Walker 2009-02-25 19:44:57 UTC
Mental note to self - also need to write a regression test.
Comment 5 Willie Walker 2009-02-27 17:03:49 UTC
(In reply to comment #4)
> Mental note to self - also need to write a regression test.

I worked on this and ended up with really strange behavior for the test.  I've committed the patch to trunk, however, since it pylints and doesn't introduce regressions.  I'll attach the current test-in-progress here after I poke at it some more.
Comment 6 Willie Walker 2009-02-27 19:03:06 UTC
Created attachment 129684 [details] [review]
Regression test that has bad behavior

Here's the test just so I don't lose it.  Of the approximately 50 times I've run it with differing pauses sprinkled throughout, it's only run successfully once.  I believe this is the one that ran fine, but it only ran successfully once and has never done so again.

The problem is that the text inserted event for the 'alert' role is being issued when the test is run by hand (i.e., a human types the characters), but it a text inserted event for a 'paragraph' is being emitted when this is run programatically.  Very strange.  Anyway, I'm giving it a rest for now.  Maybe things will be clearer the next time I look at it.
Comment 7 Willie Walker 2009-03-03 20:42:02 UTC
Closing this because the friggin' regression test is just killing me to write.  It's so ill behaved.  Sigh.