After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570493 - Drop remaining libgnomeui usage in alacarte
Drop remaining libgnomeui usage in alacarte
Status: RESOLVED FIXED
Product: alacarte
Classification: Applications
Component: general
0.11.x
Other All
: Normal normal
: ---
Assigned To: Alacarte Maintainer(s)
Alacarte Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-02-04 13:21 UTC by Andreas Proschofsky
Modified: 2009-02-16 14:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
alacarte-0.11.8-remove-libgnome.diff (1.32 KB, patch)
2009-02-04 13:25 UTC, Andreas Proschofsky 		committed Details | Review

Description Andreas Proschofsky 2009-02-04 13:21:53 UTC 
Please describe the problem:
Alacarte still uses libgnomeui in a few places, following the recent cleanup trend these would be nice to remove ;)

As far as I can see the only usage left is in MainWindow.py for displaying the help, going to attach a patch to remove this

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Andreas Proschofsky 2009-02-04 13:25:28 UTC 
Created attachment 127926 [details] [review]
alacarte-0.11.8-remove-libgnome.diff

The patches replaces gnome.help_display_desktop() with gtk.show_uri() and raises the minimal pygtk dependency to 2.13. I've also removed the usage of gnome.init() as this seems to be only used for the old help call.

Disclaimer: I'm not a programmer, so you might double check this, even if it's trivial ;)
Comment 2 Jonh Wendell 2009-02-13 16:37:22 UTC 
The patch looks good to me. I have tried it and it works fine.
Comment 3 André Klapper 2009-02-15 23:11:24 UTC 
I personally consider alacarte unmaintained.
Maybe Cosimo can take a look if he finds some time, otherwise I prefer being conservative and getting this in for 2.27.1.
Comment 4 Cosimo Cecchi 2009-02-16 14:17:42 UTC 
Committed to trunk, will be in 0.11.9.
Closing as FIXED.

2009-02-16  Cosimo Cecchi  <cosimoc@gnome.org>

	* Alacarte/MainWindow.py: drop libgnomeui dependency.
	* configure.ac: bump required PyGTK version to 2.13.0,
	due to gtk.show_uri().
	Patch by Andreas Proschofsky, fixes bug #570493.