After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570357 - make install fails on master
make install fails on master
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.25.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-02-03 13:11 UTC by Guillaume Desmottes
Modified: 2009-02-10 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Guillaume Desmottes 2009-02-03 13:11:33 UTC 
Updating Gtk icon cache.
gtk-update-icon-cache: Cache file created successfully.
make[3]: Leaving directory `/home/cassidy/gnome/empathy/data/icons'
make[2]: Leaving directory `/home/cassidy/gnome/empathy/data/icons'
make[2]: Entering directory `/home/cassidy/gnome/empathy/data'
make[3]: Entering directory `/home/cassidy/gnome/empathy/data'
make[3]: Nothing to be done for `install-exec-am'.
if test -z "" ; then \
	  for p in empathy.schemas ; do \
	    GCONF_CONFIG_SOURCE=xml:merged:/etc/gconf/gconf.xml.defaults /usr/bin/gconftool-2 --makefile-install-rule /$p ; \
	  done \
	fi
I/O warning : failed to load external entity "/empathy.schemas"
Failed to open `/empathy.schemas': No such file or directory
make[3]: *** [install-data-local] Error 1
make[3]: Leaving directory `/home/cassidy/gnome/empathy/data'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/home/cassidy/gnome/empathy/data'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/cassidy/gnome/empathy/data'
make: *** [install-recursive] Error 1
Comment 1 Frederic Peters 2009-02-03 13:27:54 UTC 
Looks like your automake doesn't provide $(builddir)

-           GCONF_CONFIG_SOURCE=$(GCONF_SCHEMA_CONFIG_SOURCE) $(GCONFTOOL) --makefile-install-rule $(builddir)/$$p ; \
 +           GCONF_CONFIG_SOURCE=$(GCONF_SCHEMA_CONFIG_SOURCE) $(GCONFTOOL) --makefile-install-rule $(top_builddir)/data/$$p ; \

should do.
Comment 2 Guillaume Desmottes 2009-02-03 15:47:03 UTC 
Indeed, then it works fine.
Comment 3 Theppitak Karoonboonyanan 2009-02-03 16:36:58 UTC 
Or better yet, without $(builddir) at all (thanks Christian Persch for the comment in bug 570327, comment #3):

Index: data/Makefile.am
===================================================================
--- data/Makefile.am    (revision 2379)
+++ data/Makefile.am    (working copy)
@@ -33,7 +33,7 @@
 install-data-local:
        if test -z "$(DESTDIR)" ; then \
          for p in $(schemas_DATA) ; do \
-           GCONF_CONFIG_SOURCE=$(GCONF_SCHEMA_CONFIG_SOURCE) $(GCONFTOOL) --makefile-install-rule $(builddir)/$$p ; \
+           GCONF_CONFIG_SOURCE=$(GCONF_SCHEMA_CONFIG_SOURCE) $(GCONFTOOL) --makefile-install-rule $$p ; \
          done \
        fi
 else
Comment 4 Theppitak Karoonboonyanan 2009-02-10 16:10:40 UTC 
OK to commit?
Comment 5 Guillaume Desmottes 2009-02-10 16:34:23 UTC 
This patch fixes my error, so I'd say +1 for me.
Comment 6 Guillaume Desmottes 2009-02-10 16:35:47 UTC 
Xavier just said on IRC he's ok with the patch too. Please commit :)

Thanks a lot for your help.
Comment 7 Theppitak Karoonboonyanan 2009-02-10 16:58:54 UTC 
Committed.
Comment 8 Guillaume Desmottes 2009-02-10 17:06:38 UTC 
Great, closing the bug.