After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569980 - live preview when trimming beginning/end points
live preview when trimming beginning/end points
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Timeline
Git
Other Linux
: Normal enhancement
: 0.91
Assigned To: Jean-François Fortin Tam
Pitivi maintainers
: 589697 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-01-31 15:25 UTC by Jean-François Fortin Tam
Modified: 2012-03-26 04:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
demonstration of the requested feature (421.87 KB, video/ogg)
2009-02-05 17:34 UTC, Jean-François Fortin Tam
Details

Description Jean-François Fortin Tam 2009-01-31 15:25:13 UTC
When dragging the left or right "edge" of a clip to set the starting/ending point, PiTiVi should show the cutting-point frame in realtime in the preview pane.
Comment 1 Jean-François Fortin Tam 2009-02-05 17:34:02 UTC
Created attachment 128025 [details]
demonstration of the requested feature

Notice the preview window above the timeline, which shows the current frame at which you are moving the end point of the clip to.

This bug is marked as NEEDINFO, anything else needed?
Comment 2 Edward Hervey 2009-07-27 10:05:06 UTC
*** Bug 589697 has been marked as a duplicate of this bug. ***
Comment 3 Brandon Lewis 2009-12-17 22:48:27 UTC
i need some suggestions for how to go about implementing this. The naive approach of seeking the timeline to the current cursor position does not seem to work very well.
Comment 4 Edward Hervey 2009-12-18 07:49:22 UTC
Temporarily switching the viewer to the source you're trimming would be the fastest/easiest way imho.

Been thinking about maybe having a way for gnlcomposition to expose other pads for 'trimming'... but it's still unclear how that would be implemented.
Comment 5 Vincent Tschanz 2011-09-18 10:46:15 UTC
I would love this feature!  It's implemented in the "precision editor" in Apple iMovie, very useful.
Comment 6 Jean-François Fortin Tam 2012-03-07 21:01:00 UTC
I am pleased to tell you that I have a working implementation for this feature in my "live-trimming-preview" branch on github. Feedback welcome!
Comment 7 Jean-François Fortin Tam 2012-03-26 04:33:39 UTC
Merged in origin/ges. Commits in reverse order:


commit 41b5c78a24b2ced31ca102741cf428439d1a50b5
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Fri Mar 23 18:22:02 2012 -0400

    viewer: Reset the pipeline to the previous position after trimming

commit 8427a2f117037b53790e83391f686a610f3466bf
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Wed Mar 7 19:16:03 2012 -0500

    viewer: Limit the live trim preview to one seek per 200 ms

commit 816a94b55301fb6647d162b7a29cfa1c52edcdc1
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Wed Mar 7 14:34:40 2012 -0500

    viewer: Clear the pipeline bus sync handler to set a new one

commit eae008544626935fa7dff9820bc537d4693652d3
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Tue Mar 6 11:17:22 2012 -0500

    Catch signals in trimming handles and ask the viewer to preview

commit e8e7296d9b7a29e729f462fdba8e9134ac87c2d7
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Mon Mar 5 16:41:29 2012 -0500

    viewer: Preview the clips being trimmed

commit 7716ce45a3628475c0080ee274e0720af26e8941
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Mon Mar 5 16:37:57 2012 -0500

    utils/timeline: emit signals when trimming clips