After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569953 - Brasero fails to build outside source dir
Brasero fails to build outside source dir
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
git master
Other Linux
: Normal minor
: 0.8
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks: 569778
 
 
Reported: 2009-01-31 08:48 UTC by Theppitak Karoonboonyanan
Modified: 2009-01-31 10:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Fixing include paths (6.37 KB, patch)
2009-01-31 08:50 UTC, Theppitak Karoonboonyanan 		committed Details | Review

Description Theppitak Karoonboonyanan 2009-01-31 08:48:12 UTC 
When building brasero outside source dir, many modules failed to build with the same error: brasero-media.h was not found.

The file appears to be generated from libbrasero-media/brasero-media.h.in, so it's supposed to be located in $(topbuilddir)/libbrasero-media. However, most Makefile.am's in the tree fail to supply that location. It's either missing or provided with just $(topbuilddir), which is not sufficient.
Comment 1 Theppitak Karoonboonyanan 2009-01-31 08:50:44 UTC 
Created attachment 127612 [details] [review]
Fixing include paths

This patch makes it build off source-dir in my machine.
Comment 2 Philippe Rouquier 2009-01-31 09:45:36 UTC 
Thanks a lot for the report and the patch. It was committed to trunk for the upcoming version.

2009-01-31  Philippe Rouquier  <ykw@localhost.localdomain>

	Fix #569953 – Brasero fails to build outside source dir
	Patch by Theppitak Karoonboonyanan

	* nautilus/Makefile.am:
	* src/Makefile.am:
	* src/plugins/cdrdao/Makefile.am:
	* src/plugins/cdrkit/Makefile.am:
	* src/plugins/cdrtools/Makefile.am:
	* src/plugins/checksum/Makefile.am:
	* src/plugins/dvdauthor/Makefile.am:
	* src/plugins/dvdcss/Makefile.am:
	* src/plugins/growisofs/Makefile.am:
	* src/plugins/libburnia/Makefile.am:
	* src/plugins/local-track/Makefile.am:
	* src/plugins/transcode/Makefile.am:
	* src/plugins/vcdimager/Makefile.am: