After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568880 - don't rely on gtk implementation details
don't rely on gtk implementation details
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
0.x.x [obsolete]
Other Linux
: Normal major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 568886
 
 
Reported: 2009-01-23 17:35 UTC by Christian Persch
Modified: 2009-01-23 20:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christian Persch 2009-01-23 17:35:44 UTC 
./src/nautilus-window-menus.c:	action = g_object_get_data (G_OBJECT (proxy),  "gtk-action");

+++ This bug was initially created as a clone of Bug #568848 +++

While testing some GtkAction changes in GTK+ trunk, I've found that epiphany uses
g_object_get_data (widget, "gtk-action") to get at the action associated with a widget in some places. 

Please don't do that. We consider that undocumented object data an implementation detail, and it will go away at some point. Instead, use the documented api  for this: gtk_widget_get_action.
Comment 1 Cosimo Cecchi 2009-01-23 20:27:13 UTC 
Fixed in trunk, thanks.

2009-01-23  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/nautilus-window-menus.c
	(menu_item_select_cb): don't rely on GTK+ implementation details
	when getting a GtkAction.
	Thanks to Christian Persch (#568880).