Bug 568840 – please ignore (big) binary files

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 568840 - please ignore (big) binary files


Summary:	please ignore (big) binary files


Status:	RESOLVED FIXED

Product:	gnome-utils
Classification:	Deprecated
Component:	gsearchtool
Version:	2.20.x
Hardware:	Other Linux

Importance:	Normal enhancement
Target Milestone:	---
Assigned To:	gnome-utils Maintainers
QA Contact:	gnome-utils Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-01-23 14:04 UTC by Josselin Mouette
Modified:	2009-03-30 01:23 UTC

See Also:
GNOME target:	---
GNOME version:	2.21/2.22

Description Josselin Mouette 2009-01-23 14:04:52 UTC

[ Original report: http://bugs.debian.org/507737 from Luís Picciochi ]

  When searching for files that contain a given text, gnome-search-tool 
should ignore binary files.
  Looking inside binary files can have a big impact on how long a search 
takes when the (sub-)directories have huge binary files - a lot of time 
is spent looking for text in those files, sometimes possibly even 
giving them as as results, when this time should not be spent grepping 
them.

  I'm not sure if this should be an importat or wishlist bug, but under 
certain circumstances the search might get extremely slow, making the 
user get frustrated and quit the search.

Comment 1 Dennis Cranston 2009-03-30 01:23:43 UTC

Thanks for your bug report.  Patch applied to version 2.27.1 in SVN.

2009-03-29  Dennis Cranston  <dennis_cranston@yahoo.com>

	* gsearchtool.c (setup_case_insensitive_arguments): If grep
	supports the -I argument then use it. Bug 568840.