After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567982 - "queued_bytes" field isn't updated while flushing the queue in gstappsrc.c
"queued_bytes" field isn't updated while flushing the queue in gstappsrc.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.21
Other Linux
: Normal normal
: 0.10.23
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-16 14:26 UTC by Vikram Fugro
Modified: 2009-01-23 10:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
Proposed Patch (354 bytes, patch)
2009-01-16 14:36 UTC, Vikram Fugro 		none Details | Review

Description Vikram Fugro 2009-01-16 14:26:25 UTC 
The "queued_bytes" field is not updated while flushing the queue in gstappsrc.c
This could cause problems indicating the queue has some data even when queue has been flushed.
Comment 1 Vikram Fugro 2009-01-16 14:36:14 UTC 
Created attachment 126583 [details] [review]
Proposed Patch
Comment 2 Jan Schmidt 2009-01-16 15:04:18 UTC 
appsrc and friends are in gst-plugins-base now, changing component.
Comment 3 Wim Taymans 2009-01-16 17:01:31 UTC 
or even:

Index: gstappsrc.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst-libs/gst/app/gstappsrc.c,v
retrieving revision 1.18
diff -u -B -b -p -r1.18 gstappsrc.c
--- gstappsrc.c 6 Jan 2009 11:10:29 -0000       1.18
+++ gstappsrc.c 16 Jan 2009 17:00:07 -0000
@@ -501,6 +501,7 @@ gst_app_src_flush_queued (GstAppSrc * sr

   while ((buf = g_queue_pop_head (src->priv->queue)))
     gst_buffer_unref (buf);
+  src->priv->queued_bytes = 0;
 }

 static void
Comment 4 Wim Taymans 2009-01-23 10:10:05 UTC 
commit f300cd83bfc86832bf276af955c058ccdf999efe
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Jan 23 11:07:05 2009 +0100

    Reset queued_bytes counter when flushing
    
    Set the amount of queued bytes in the internal queue back to 0 when we clear the
    queue.
    Fixes #567982