After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 567027 - Add GType for GstRTSPUrl for bindings
Add GType for GstRTSPUrl for bindings
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-01-08 14:22 UTC by Wim Taymans
Modified: 2009-01-08 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to make a boxed GType for GstRTSPUrl (2.35 KB, patch)
2009-01-08 14:23 UTC, Wim Taymans 		none Details | Review
improved patch (4.15 KB, patch)
2009-01-08 15:20 UTC, Wim Taymans 		none Details | Review
improved patch (4.06 KB, patch)
2009-01-08 15:43 UTC, Wim Taymans 		committed Details | Review

Description Wim Taymans 2009-01-08 14:22:45 UTC 
The GstRTSPUrl struct needs to have a boxed GType so that bindings can wrap it.
Comment 1 Wim Taymans 2009-01-08 14:23:27 UTC 
Created attachment 126033 [details] [review]
Patch to make a boxed GType for GstRTSPUrl
Comment 2 Wim Taymans 2009-01-08 15:20:36 UTC 
Created attachment 126038 [details] [review]
improved patch

Improved patch
 * use GOnce
 * update docs and defs
 * Add a type define
Comment 3 Tim-Philipp Müller 2009-01-08 15:29:31 UTC 
Comment on attachment 126038 [details] [review]
improved patch

>+  /* work around thread-safety issue with class creation in GLib */
>+  g_type_class_ref (*id);

I think boxed types are unclassed and this will lead to a GObject warning. Have you tried it?
Comment 4 Wim Taymans 2009-01-08 15:43:35 UTC 
Created attachment 126040 [details] [review]
improved patch

without the _class_ref() and tested.
Comment 5 Wim Taymans 2009-01-08 17:18:24 UTC 
        * docs/libs/gst-plugins-base-libs-sections.txt:
        * gst-libs/gst/rtsp/gstrtspurl.c: (register_rtsp_url_type),
        (gst_rtsp_url_get_type), (gst_rtsp_url_copy):
        * gst-libs/gst/rtsp/gstrtspurl.h:
        * win32/common/libgstrtsp.def:
        Add GType for GstRTSPUrl and expose a copy function because we can.
        API: gst_rtsp_url_copy()
        Fixes #567027.