GNOME Bugzilla – Bug 566546
[PATCH] Implement aggressive block selection
Last modified: 2012-01-31 23:22:44 UTC
Please describe the problem: Sometimes, gnometris is not evil enough. This patch adds mode which makes tetris play a very frustrating experience: Subject: Gnometris is way TOO FRIENDLY From: Lubomir Rintel <lkundrak@v3.sk> This adds inpopular [1] "Bastard" mode to gnometris. The idea is to annoy the user with intentionally unsuitable pieces. It also annoys the user by displaying the most suitable piece instead of the next to come. In order to make it a bit fun, it is not that evil. It more-or-less picks from three worst pieces giving the highest chance to the worst one. The idea comes from "bastet" [2], which stands for "Bastard Tetris". This shares the algorithm, but no code. [1] http://games.slashdot.org/games/05/04/24/1259241.shtml?tid=208&tid=106 [2] http://fph.altervista.org/prog/bastet.shtml Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 125749 [details] Adds "bastard" mode to gnometris
Ping?
We are past feature freeze for 2.26. Jason, do we want this for 2.28? Seems like a fun idea to me.
Target set for 2.28. Patch might need to be regenerated after merge of more clutter changes.
Created attachment 127750 [details] Adds "bastard" mode to gnometris (patch against r8630) (In reply to comment #4) > Target set for 2.28. Patch might need to be regenerated after merge of more > clutter changes. Done. I did not test the result yet since I run older GNOME desktop on my work laptop, but adapting the patch against 8630 was rather straightforward.
I don't consider this a 2.28 blocker (looks more like enhancement to me), hence unsetting gnome target and setting target milestone.
I'm not very familiar with the way features are added into Gnome -- is there something I can do to help getting this reviewed and eventually integrated?
We are not adding any new features, only bugfixes, until we release 2.26 on 18th March. Jason is doing a lot of changes to gnometris that might break your patch. Whay you can do is to keep the patch updated until we branch. (pinging us is a good idea too)
Created attachment 130587 [details] Adds "bastard" mode to gnometris (patch against r8824) Patch updated for the actual source. Note that the algorithm is duplicated in blockops.cpp and blockops-noclutter.cpp, as is the rest of the actual block selection logic. I could eventually split it to a separate file, but it would make little sense w/o getting rid of the rest of duplicated code. I suspect you may have plans to do something about it.
*ping* *ping* Hello! Past the freeze now, I guess? The attachment #130587 [details] patch still applies.
(In reply to comment #8) > (pinging us is a good idea too) *Halooooo*
Sorry for the wait Lubomir. And thanks for pinging. Jason is busy rewriting a lot of gnometris in clutter. The changes may conflict with your patch and that is why it has not been included yet. Hopefully the new gnometris will be ready and we will get to getting your work included. Thanks for working on this!
I will get this in hopefully soon. I should probably merge it in my private branch first. I'll update the bug when I merge.
ping
Any progress here? Anything I can help with?
Created attachment 136050 [details] Adds "bastard" mode to gnometris (patch against 3ebe4f7)
I'll merge this before the next devel. release. Thanks!
Released in 2.27.3.
This bug is being reassigned to the "quadrapassel" component so we can close the gnometris bugzilla component. Apologies for the mass email!