GNOME Bugzilla – Bug 566454
Literal values should be kept between double quotes
Last modified: 2009-01-20 20:06:23 UTC
It seems that "title", "name", "link" and "type" shouldn't be translated in this messages, from src/dh-parser.c: "title, name, and link elements are required at line %d, column %d" "name and link elements are required inside <sub> on line %d, column %d" "name and link elements are required inside '%s' on line %d, column %d" "type element is required inside <keyword> on line %d, column %d" If this is correct, please place the names between double quotes.
Created attachment 125714 [details] [review] Enclosed element names in double quotes http://live.gnome.org/TranslationProject/DevGuidelines/Enclose%20literal%20values%20in%20double%20quotes
Looks good, but I'd say we keep it until after the next release as it would cause unnecessary work for translators now.
This is a good time to fix strings which are marked for translation. We're not in string freeze; we just need to tell gnome-i18n@ we changed the strings. After the string freeze there will be much more translations -- and some will be misleading, because the translators didn't understand the original message. (In fact, there are probably some wrong translations now.)
OK. Also, as it turns out, webkit got rejected again so we are not going to use trunk in gnome 2.26 anyway, so we can do anything anyway... so feel free to commit. Thanks!
2009-01-20 Leonardo Ferreira Fontenelle <leonardof@gnome.org> reviewed by: Richard Hult. * src/dh-parser.c: (parser_start_node_book), (parser_start_node_chapter), (parser_start_node_keyword): Enclosed the elements names between double quotes in some error messages. Closes bug #566454.