GNOME Bugzilla – Bug 566436
Use GIO
Last modified: 2010-02-11 13:39:13 UTC
instead of gnome-vfs.
$:andre\> grep -r vfs . ./src/lb-utils.c:#include <libgnomevfs/gnome-vfs.h> ./src/lb-utils.c: info = gnome_vfs_file_info_new (); ./src/lb-utils.c: result = gnome_vfs_get_file_info ( ./src/lb-utils.c: gnome_vfs_file_info_unref (info); ./src/lb-utils.c: gnome_vfs_file_info_unref (info); ./src/lb-utils.h:#include <libgnomevfs/gnome-vfs-file-info.h> ./src/lb-item-file.c: gnome_vfs_mime_application_launch (info->application, &list); ./src/lb-module-files.c:#include <libgnomevfs/gnome-vfs.h> ./src/lb-module-files.c:#include <libgnomevfs/gnome-vfs-mime-handlers.h> ./src/lb-module-files.c:#include <libgnomevfs/gnome-vfs-file-info.h> ./src/lb-module-files.c: r = gnome_vfs_directory_open (&handle, priv->dir_uri, ./src/lb-module-files.c: g_warning("error opening %s: %s", priv->dir_uri, gnome_vfs_result_to_string(r)); ./src/lb-module-files.c: info = gnome_vfs_file_info_new (); ./src/lb-module-files.c: while (gnome_vfs_directory_read_next (handle, info) == GNOME_VFS_OK) { ./src/lb-module-files.c: gnome_vfs_file_info_clear (info); ./src/lb-module-files.c: gnome_vfs_directory_close (handle); ./src/lb-module-files.c: info = gnome_vfs_file_info_new (); ./src/lb-module-files.c: if (gnome_vfs_get_file_info (lb_item_file_get_uri (item_file), ./src/lb-module-files.c: gnome_vfs_file_info_unref (info); ./src/lb-module-files.c: default_application = gnome_vfs_mime_get_default_application (mime_type); ./src/lb-module-files.c: applications = gnome_vfs_mime_get_all_applications (mime_type); ./src/lb-module-files.c: icon = gnome_vfs_mime_application_get_icon (application); ./src/lb-module-files.c: name = gnome_vfs_mime_application_get_name (application); ./src/lb-module-files.c: gnome_vfs_mime_application_free); ./src/lb-module-files.c: if (gnome_vfs_mime_application_equal (application, default_application)) { ./src/lb-module-files.c: gnome_vfs_mime_application_launch (application, &list); ./src/lb-main.c:#include <libgnomevfs/gnome-vfs-init.h> ./src/lb-main.c: gnome_vfs_init (); ./configure.ac: gnome-vfs-2.0 >= 2.10 ./tests/search-applications.c:#include <libgnomevfs/gnome-vfs.h> ./tests/search-applications.c: gnome_vfs_init (); ./tests/search-applications.c: gnome_vfs_shutdown (); ./tests/search-home.c:#include <libgnomevfs/gnome-vfs.h> ./tests/search-home.c: gnome_vfs_init (); ./tests/mime-actions.c:#include <libgnomevfs/gnome-vfs.h> ./tests/mime-actions.c:#include <libgnomevfs/gnome-vfs-mime-handlers.h> ./tests/mime-actions.c: applications = gnome_vfs_mime_get_all_applications (info->mime_type); ./tests/mime-actions.c: const gchar *name = gnome_vfs_mime_application_get_name (application); ./tests/mime-actions.c: const gchar *icon = gnome_vfs_mime_application_get_icon (application); ./tests/mime-actions.c: gnome_vfs_init (); ./tests/mime-actions.c: info = gnome_vfs_file_info_new (); ./tests/mime-actions.c: result = gnome_vfs_get_file_info (uri, info, ./tests/mime-actions.c: gnome_vfs_result_to_string (result));
Created attachment 136776 [details] [review] Some love for a forgotten app Hey guys, you have a great start here. This isn't a perfect patch but it is 95% working for me. I plan on putting some more work on gnome-launch-box to integrate it better with some of the work we are doing with gnome-shell. GNOME 3.0 here we come.
(In reply to comment #2) > Created an attachment (id=136776) [edit] > Some love for a forgotten app > > Hey guys, you have a great start here. This isn't a perfect patch but it is > 95% working for me. I plan on putting some more work on gnome-launch-box to > integrate it better with some of the work we are doing with gnome-shell. GNOME > 3.0 here we come. Can you please enlighten me on the missing 5%? What's not working for you?
the icons were not populating correctly in the launch menu after a document was selected. I have ironed out that bug and am working on general cleanup and enhancements. Will try and post an updated patch soon.
(In reply to comment #4) > the icons were not populating correctly in the launch menu after a document was > selected. I have ironed out that bug and am working on general cleanup and > enhancements. Will try and post an updated patch soon. Cool, when reposting a git commit, please set your full name and email address properly with git-config (user.name and user.email settings).
Created attachment 136916 [details] [review] complete port of existing codebase to gio Sorry I missed the name email config problem. I have that set but for some reason git tends to not update it on some projects. Just another bit of git quirkiness I guess. This patch is complete minus one line that references vfs that is commented out.
I accidentally closed the bug. Unfortunately I cannot test the patch right now, I'll try to have time for it in the next two weeks (will have to upgrade this system before). If you don't hear from me, feel free to reping.
*** Bug 590827 has been marked as a duplicate of this bug. ***
(In reply to comment #7) > in the next two weeks. If you don't hear from me, feel free to reping. Sven: reping.
Hey guys any word on this? I have been sucked in by a couple of other projects so haven't had times to update this at all.
This is finally done: http://git.gnome.org/browse/gnome-launch-box/commit/?id=e1a4581265c19a6638126511e0d93d4006dc9d6e