After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 566060 - Integrate to podiff
Integrate to podiff
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: vertimus
unspecified
Other All
: Normal enhancement
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
: 566558 567022 568432 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-12-30 15:41 UTC by Stephane Raimbault
Modified: 2012-10-17 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Generating a patch-like diff instead of html table (2.16 KB, patch)
2009-01-18 00:28 UTC, Og Maciel
none Details | Review
Side by side diff view of two versions of a po file (140.49 KB, image/png)
2009-01-18 19:33 UTC, Claude Paroz
  Details

Description Stephane Raimbault 2008-12-30 15:41:25 UTC
It'd be great to have links to a diff file (made with podiff, since else it's useless) when you attach a new po file.

Ideally, you'd have:
 + podiff with the current translation in svn (the one that can be downloaded from damned-lies)
 + podiff with the previously attached translations (for example, when you do a review a translation and change a few strings)

This feature is already available in Transifex :)
Comment 1 Claude Paroz 2009-01-04 22:05:33 UTC
*** Bug 566558 has been marked as a duplicate of this bug. ***
Comment 2 Claude Paroz 2009-01-08 14:15:42 UTC
*** Bug 567022 has been marked as a duplicate of this bug. ***
Comment 3 Leonardo Ferreira Fontenelle 2009-01-10 13:48:04 UTC
This bug report has some overlap with #550208.
Comment 4 Claude Paroz 2009-01-17 22:55:23 UTC
Preliminary work has been committed in rev. 1357 (not in production yet). There is still improvements ahead regarding po specific syntax. I just used standard Python difflib.HtmlDiff functionality for now.
Comment 5 Og Maciel 2009-01-18 00:28:46 UTC
Created attachment 126668 [details] [review]
Generating a patch-like diff instead of html table

I've attached a patch that uses bzr's bzrlib.patiencediff to generate a diff that is similar to those used to generate patches. As this is not html, the css would have to be tweaked.
Comment 6 Claude Paroz 2009-01-18 19:31:47 UTC
Og, could you please:
- join a screenshot example of the resulting diff page with your version (I will also join one)
- explain why you think that a classical diff view would be superior to a side-by-side diff view.
It's possible that both views address different use cases.
Comment 7 Claude Paroz 2009-01-18 19:33:06 UTC
Created attachment 126710 [details]
Side by side diff view of two versions of a po file
Comment 8 Og Maciel 2009-01-18 20:07:30 UTC
Hi Claude, as I don't have vertimus operational on my checkout version of d-l, I do not have a html-rendered output of what my patch produces. However, this what you could expect as the output, minus html/css styles:

+#: ../app/create_object.c:71
+#, c-format
+msgid "'%s' creation failed"
+msgstr "Falha ao criar \"%s\""

 #: ../data/gnome-packagekit.schemas.in.h:49
-#, fuzzy
 msgid "Use WiFi (wireless LAN) connections to check for updates"
-msgstr "Com que freqüência deve-se verificar por atualizações"
+msgstr "Usa conexões WiFi (LAN sem fio) para verificar atualizações"

It could be just the developer in me, but I find this to be relatively easier to follow than to look at side-by-side diffs. I don't know what use cases you have for this diff view and may well be that translators will cringe at looking at such output as the one I've suggested, but for someone doing the actual commit, a patch-like view may be easier to follow? Just my 2 cents.

Cheers,

Og
Comment 9 Stephane Raimbault 2009-01-20 14:38:16 UTC
*** Bug 568432 has been marked as a duplicate of this bug. ***
Comment 10 Vincent Untz 2009-01-20 14:50:08 UTC
Move this to the right component if you want to avoid duplicates ;-)