After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565879 - isoinfo.sh has shebang but is installed -x
isoinfo.sh has shebang but is installed -x
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
unspecified
Other Linux
: Normal trivial
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2008-12-28 20:06 UTC by Loïc Minier
Modified: 2009-01-19 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't call script within sh, and fix its perms by using _SCRIPTS instead of _DATA as automake type (1.03 KB, patch)
2008-12-28 20:13 UTC, Loïc Minier 		none Details | Review
Drop shebang of isoinfo.sh (225 bytes, patch)
2008-12-28 20:56 UTC, Loïc Minier 		none Details | Review

Description Loïc Minier 2008-12-28 20:06:45 UTC 
Hi,

This is a really minor bug, but it poppped on my radar when the Debian package checker "lintian" raised this warning to me:
    *   W script-not-executable
          o ./usr/lib/file-roller/file-roller/isoinfo.sh

    This file starts with the #! sequence that marks interpreted scripts, but it is not executable.

It's easy enough to workaround this in the packaging, but eh why not fix it upstream.

I suggest that you either drop the shebang, or fix the permissions in SVN and apply the patch I'll attach which uses _SCRIPTS as the automake type instead of _DATA.

Cheers,
Comment 1 Loïc Minier 2008-12-28 20:10:07 UTC 
Note that file-roller calls "sh isoinfo.sh", so it's really assumed to be a shell script, and the shebang isn't used.
Comment 2 Loïc Minier 2008-12-28 20:13:00 UTC 
Created attachment 125444 [details] [review]
Don't call script within sh, and fix its perms by using _SCRIPTS instead of _DATA as automake type

Note that you need to fix the SVN perms as well if you pick this patch.
Comment 3 Loïc Minier 2008-12-28 20:56:33 UTC 
Created attachment 125447 [details] [review]
Drop shebang of isoinfo.sh

Alternatively, drop shebang of this shell script.
Comment 4 Paolo Bacchilega 2009-01-19 11:18:56 UTC 
I applied the second one, thanks