After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565388 - Remove libgnomeui dependency
Remove libgnomeui dependency
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: gfloppy
trunk
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-22 21:12 UTC by Emilio Pozuelo Monfort
Modified: 2008-12-23 01:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
remove libgnomeui dependency from gfloppy (1.55 KB, patch)
2008-12-22 21:13 UTC, Emilio Pozuelo Monfort 		none Details | Review

Description Emilio Pozuelo Monfort 2008-12-22 21:12:23 UTC 
Hi,

The attached patch removes the libgnomeui dependency from gfloppy, 'couse libgnome must die!

http://live.gnome.org/LibgnomeMustDie
Comment 1 Emilio Pozuelo Monfort 2008-12-22 21:13:27 UTC 
Created attachment 125155 [details] [review]
remove libgnomeui dependency from gfloppy
Comment 2 Cosimo Cecchi 2008-12-23 00:28:14 UTC 
Thanks for the patch, I committed it to trunk with some additional fixes:

- there's no need to call gtk_init () if you do g_option_context_parse () after adding the GTK+ option group to it with gtk_get_option_group (TRUE).
- you should call exit (1) if the option context isn't parsed.
- you should free the option context after it has been parsed
- the correct syntax for showing ghelp uris with gtk_show_uri is ghelp:modulename#section

Closing as FIXED.

2008-12-23  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/main.c (on_help_button_clicked), (main):
	Remove libgnome/libgnomeui dependency.
	Thanks to Emilio Pozuelo Monfort (#565388).
Comment 3 Emilio Pozuelo Monfort 2008-12-23 01:01:43 UTC 
Thanks a lot for the comments Cosimo!

btw I used "ghelp:gfloppy?usage" because that's what http://live.gnome.org/action/edit/GnomeGoals/RemoveGnomeOpenGnomeHelp recommends (and it works). Maybe that needs fixing :)