After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564237 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED INVALID
Product: swfdec-gnome
Classification: Deprecated
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: swfdec-gnome-maint
swfdec-gnome-maint
Depends on:
Blocks: 563413
 
 
Reported: 2008-12-12 11:51 UTC by Przemysław Grzegorczyk
Modified: 2009-01-09 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
swfdec-gnome patch (371 bytes, patch)
2008-12-12 11:51 UTC, Przemysław Grzegorczyk 		none Details | Review

Description Przemysław Grzegorczyk 2008-12-12 11:51:27 UTC 
http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Przemysław Grzegorczyk 2008-12-12 11:51:58 UTC 
Created attachment 124514 [details] [review]
swfdec-gnome patch
Comment 2 Luis Menina 2009-01-08 00:58:45 UTC 
Could someone please review this ?
Comment 3 Benjamin Otte (Company) 2009-01-08 07:50:35 UTC 
I don't think this patch is correct as my glib.h doesn't include glib/gprintf.h.
I'm not running a glib development version, so this might have changed though. Has anybody tried compiling swfdec-gnome with that patch?
Comment 4 Luis Menina 2009-01-09 00:59:22 UTC 
It builds well with or without the patch with G_DISABLE_DEPRECATED G_DISABLE_SINGLE_INCLUDES GDK_PIXBUF_DISABLE_SINGLE_INCLUDES and GTK_DISABLE_SINGLE_INCLUDES defined... So you can do whatever you think is best.
Comment 5 Przemysław Grzegorczyk 2009-01-09 20:59:11 UTC 
Oops.. Sorry, this patch is not needed. I was coding too much that day :]
Closing this bug.