After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564209 - Improved debuggability for module loading
Improved debuggability for module loading
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Engine
2.2.x
Other All
: Normal enhancement
: ---
Assigned To: Derek Atkins
Derek Atkins
Depends on:
Blocks: backport
 
 
Reported: 2008-12-12 05:52 UTC by G. Paul Ziemba
Modified: 2018-06-29 22:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (3.73 KB, patch)
2008-12-12 05:59 UTC, G. Paul Ziemba
committed Details | Review

Description G. Paul Ziemba 2008-12-12 05:52:59 UTC
gnucash-2.2.7 doesn't (IMHO) log enough (any?) information about failures to load optional modules. It was a bit of work to debug a recent problem (564033) and I ended up tweaking gnc_module_load_common() a bit to coax the error messages out. I slightly reorganized the code in this function to accomplish two things:

1. Make the logic clearer to someone new to the code (i.e., me)
2. If an optional module is found, log any errors in loading it

I tried to maintain the original spirit of not squawking too much about unfound optional modules while still generating messages about legitimate problems. I think it would be a useful change for others; hope you agree!

There doesn't seem to be a way of uploading a patch with this bug report, so I have put it here: http://www.sonic.net/~enrico/patches/gnucash-2.2.7/patch-src-gnc-module-gnc-module.c
Comment 1 G. Paul Ziemba 2008-12-12 05:59:33 UTC
Created attachment 124487 [details] [review]
proposed patch
Comment 2 Christian Stimming 2008-12-14 09:18:42 UTC
Looks good to me.
Comment 3 Christian Stimming 2009-01-14 20:04:21 UTC
Trunk, r17818, thanks a lot!
Comment 4 Christian Stimming 2009-01-31 10:47:35 UTC
2.2-branch, r17858
Comment 5 John Ralls 2018-06-29 22:13:38 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=564209. Please update any external references or bookmarks.