After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563449 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED INVALID
Product: vinagre
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks: 563413
 
 
Reported: 2008-12-06 14:09 UTC by Bruno Boaventura
Modified: 2008-12-06 18:11 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
initial patch (4.27 KB, patch)
2008-12-06 14:30 UTC, Bruno Boaventura 		rejected Details | Review

Description Bruno Boaventura 2008-12-06 14:09:21 UTC 
GTK+ is moving toward a model where it is only allowed to include the 'toplevel' headers. Only <glib.h>, <gdk/gdk.h>, <gdk-pixbuf/gdk-pixbuf.h> and <gtk/gtk.h> can be directly included. The goal is to make all GNOME modules comply with this.
Comment 1 Bruno Boaventura 2008-12-06 14:30:20 UTC 
Created attachment 124053 [details] [review]
initial patch

I think there must be other headers to change, but it's a start
Comment 2 Cosimo Cecchi 2008-12-06 14:47:40 UTC 
I'm not a Vinagre maintainer, but the patch is wrong. glib/gi18n.h and gdk/gdkkeysyms.h should be included as separate headers anyway, as they aren't part of glib.h and gdk/gdk.h.
Also, the right include for gdk is not <gdk.h> but <gdk/gdk.h> and you seem to include <glib.h> twice.
Comment 3 Bruno Boaventura 2008-12-06 15:55:00 UTC 
Thanks Cosimo... I think I did the things in a hurry. :-)
Comment 4 Bruno Boaventura 2008-12-06 15:59:25 UTC 
Stupid me! Vinagre not need change for this goal. Closing bug.