After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563143 - ximagesink/xvimagesink : _alloc_buffer returns non-clean buffers
ximagesink/xvimagesink : _alloc_buffer returns non-clean buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-03 17:12 UTC by Edward Hervey
Modified: 2008-12-03 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Clear flags of buffer (1.23 KB, patch)
2008-12-03 17:15 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2008-12-03 17:12:23 UTC
When using the image pool from x(v)imagesink, it doesn't clear the previously-set buffer flags if it uses a buffer from its pool.

This causes obvious screwups with elements using those buffers (expecting them to be AS IF they were freshly created buffers).
Comment 1 Edward Hervey 2008-12-03 17:15:48 UTC
Created attachment 123884 [details] [review]
Clear flags of buffer

This patch clears the flags of the buffers taken from the pool.
Comment 2 Edward Hervey 2008-12-03 17:48:39 UTC
2008-12-03  Edward Hervey  <edward.hervey@collabora.co.uk>

	* sys/ximage/ximagesink.c: (gst_ximagesink_buffer_alloc):
	* sys/xvimage/xvimagesink.c: (gst_xvimagesink_buffer_alloc):
	Clear all flags on buffers returned from the image pool.
	Fixes #563143