After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562920 - Slide in the sidebar as the overlay appears
Slide in the sidebar as the overlay appears
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2008-12-01 22:32 UTC by Owen Taylor
Modified: 2008-12-01 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Slide in the sidebar as the overlay appears (5.84 KB, patch)
2008-12-01 22:34 UTC, Owen Taylor
reviewed Details | Review

Description Owen Taylor 2008-12-01 22:32:44 UTC
There's an obvious inconsistency in this patch between what I did
to AppDisplay where I added an actor property that mirrors 
AppDisplay._grid and to SideShow where I renamed AppDisplay._group
to AppDisplay._actor. This basically reflects indecision, but
the renaming seemed less obvious for AppDisplay where the information
that the actor was a grid was more relevant than the information
that the actor was a generic group.
===
appdisplay.js: Add AppDisplay.actor property, remove the x/y parameters
  to the constructor, and don't automatically add the appdisplay
  to the stage.

overlay.js: Make the AppDisplay a child of the SideShow, rename
  SideShow._grid to SideShow.actor and slide the SideShow in when
  showing the stage.
Comment 1 Owen Taylor 2008-12-01 22:34:30 UTC
Created attachment 123766 [details] [review]
Slide in the sidebar as the overlay appears
Comment 2 Colin Walters 2008-12-01 22:42:08 UTC
Looks reasonable.
Comment 3 Owen Taylor 2008-12-01 22:43:24 UTC
Committted.