After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562762 - [REGRESSION] adblock no longer works in WebKit port
[REGRESSION] adblock no longer works in WebKit port
Status: RESOLVED FIXED
Product: epiphany-extensions
Classification: Deprecated
Component: adblock
master
Other Linux
: Normal major
: ---
Assigned To: epiphany-extensions-maint
epiphany-extensions-maint
Depends on: 540781
Blocks:
 
 
Reported: 2008-11-30 13:51 UTC by Luca Ferretti
Modified: 2009-09-07 17:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Description Luca Ferretti 2008-11-30 13:51:22 UTC 
As per summary, it seems that adblock extension don't work in epiphany-webkit

However, runnin epiphany in gdb I found thi warning:
0x080d4cac in trap_handler (log_domain=0x0, log_level=<value optimized out>, 
    message=0x8fe9770 "/opt/gnome2/lib/epiphany/2.25/extensions/libadblockextension.so: undefined symbol: ephy_embed_reload", user_data=0x0) at ephy-debug.c:146
146				G_BREAKPOINT ();

In epiphany/src/window-commands.c there is this memo:
    /* FIXME: no way to bypass cache when reloading
     * with WebKit right now. Old code did:
     * ephy_embed_reload (embed, event_with_shift ());
     * WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=19815
     */
    webkit_web_view_reload (EPHY_GET_WEBKIT_WEB_VIEW_FROM_EMBED (embed));
Comment 1 Xan Lopez 2009-02-21 12:41:54 UTC 
That was a bug but not really relevant (already fixed). AFAICT this does not work simply because we are never emitting the adblock signals in the webkit port now. Looking into it now.
Comment 2 Xan Lopez 2009-02-21 12:45:14 UTC 
I meant that basically we are never checking with adblock about whether or not we should block resources from loading, because I'm not sure there's API for this yet in WebKit/GTK+.
Comment 3 Nguyen Thai Ngoc Duy 2009-06-30 00:31:06 UTC 
There isn't such API, it seems to me. Do you know any open source webkit-based browsers that do adblocking? I'd like to look into it.
Comment 4 Gustavo Noronha (kov) 2009-09-07 17:23:06 UTC 
We have added the API, and I just pushed a fix to master, thanks.