Created attachment 123345 [details] [review]
Add hardcoded default applications list taken from online.gnome.org

Looks reasonable, two thing I see:

+// TODO - move this into GConf once we're not a plugin anymore
+// but have taken over metacity

I thought that it was more something to move into GConf once we figured
out how to deal with getting GConf to find our schemas?

+    _removeItem: function(item) {
+        let group = item.actor;
+	group.destroy();
+	delete this._displayed[appid];
+    },

appid doesn't seem to be defined.

- Owen

Thanks for the review.  My thought for now is to punt on GConf; doing it correctly would involve setting up po/*, intltool etc. for our plugin.  I'm leaning towards pushing as quickly as possible to become integrated into metacity (instead of being a plugin) and thus being able to use the existing autogoo/intltool/gettext/schemas etc. infrastructure inside metacity itself.

Fixed the appid issue.

Created attachment 123384 [details] [review]
Add hardcoded default applications list taken from online.gnome.org

The previous list of all applications in a random order was obviously
temporary.  This patch improves things by adding a static list, taken
from the online.gnome.org/applications data.

In the future we will either have a vendor-chosen static list, or
a fully dynamic system.

Currently, I'd say it looks like  single source tree with mutter and no plugin
is months off, because of the requirements for mutter.

Months?  Ug.  Well so far this is the only configuration entry needed, correct?  Seems like it might make the most sense to invest in the temporary GConf infrastructure when we get to the point of having multiple items.  What do you think?

I think it's fine for now, I was mostly commenting on the explanatory comment.

This is in now - will submit bigger picture apps changes as a new bug.