After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561821 - Add orientation API to GtkButtonBox
Add orientation API to GtkButtonBox
Status: RESOLVED DUPLICATE of bug 584598
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 541009
 
 
Reported: 2008-11-21 15:39 UTC by Michael Natterer
Modified: 2009-06-15 02:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch implementing the above (40.57 KB, patch)
2008-11-21 15:44 UTC, Michael Natterer 		needs-work Details | Review

Description Michael Natterer 2008-11-21 15:39:28 UTC 
See bug #541009.

Here are the patches for GtkButtonBox and subclasses.
Comment 1 Michael Natterer 2008-11-21 15:44:23 UTC 
Created attachment 123180 [details] [review]
Patch implementing the above
Comment 2 Matthias Clasen 2008-11-26 04:49:48 UTC 
Looks good to me
Comment 3 Michael Natterer 2008-11-27 10:08:10 UTC 
I just noticed that with my patch, calling any of the deprecated

gtk_hbutton_box_set_layout_default() and
gtk_vbutton_box_set_layout_default()

changes the default layout for all button boxes.

Can we live with that tiny breakage of deprecated API, or do we need
some evil compat code here? It would be as easy as attaching the default
layout to the class, and using that in GtkBBox.
Comment 4 Michael Natterer 2008-11-27 10:21:36 UTC 
Moreover, the "default spacing" set via the deprecated APIs is never used,
so i can remove the code I added to gtkbboc.[ch] again. Will commit an updated
patch that addresses both issues.
Comment 5 Danielle Madeley 2009-06-02 12:10:13 UTC 
Bug #584598 has an alternative patch for the same thing but which should preserve the deprecated API. It's worth noting that default_spacing never seems to have been used in the size_request or size_allocate methods.
Comment 6 Danielle Madeley 2009-06-15 02:01:31 UTC 

*** This bug has been marked as a duplicate of 584598 ***