After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561351 - Cleaning up GTK Includes in gvfs
Cleaning up GTK Includes in gvfs
Status: RESOLVED DUPLICATE of bug 563788
Product: gvfs
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-18 12:09 UTC by Maxim Ermilov
Modified: 2009-10-09 20:37 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Patch for this bug (2.88 KB, patch)
2008-11-18 16:15 UTC, Maxim Ermilov 		reviewed Details | Review
corrected patch (3.29 KB, patch)
2008-11-21 18:13 UTC, Maxim Ermilov 		reviewed Details | Review

Description Maxim Ermilov 2008-11-18 12:09:26 UTC 
I'm working on implementing http://live.gnome.org/GnomeGoals/CleanupGTKIncludes

If it's not a good idea, or not currently on the agenda, please let me know.
Otherwise I'll be working on this for now.
Comment 1 Maxim Ermilov 2008-11-18 16:15:44 UTC 
Created attachment 122950 [details] [review]
Patch for this bug
Comment 2 Wouter Bolsterlee (uws) 2008-11-21 15:41:17 UTC 
Patch looks good to me, but the mighty maintainers have to decide ;)
Comment 3 Matthias Clasen 2008-11-21 16:34:15 UTC 
@@ -27,7 +27,7 @@
 #include <string.h>
 #include <glib.h>
 #include <glib/gi18n.h>
-#include <glib/gurifuncs.h>
+#include <glib.h>
 #include <gio/gio.h>
 #include <gconf/gconf-client.h>


Looks to me like this hunk (and a bunch of others) add duplicate includes of glib.h
Comment 4 Maxim Ermilov 2008-11-21 18:13:03 UTC 
Created attachment 123188 [details] [review]
corrected patch
Comment 5 Matthias Clasen 2008-12-05 21:07:31 UTC 
Looks good to me now.
Comment 6 Andreas Henriksson 2009-02-12 08:56:31 UTC 
The patch doesn't apply anymore and needs to be updated.
(please also remove the double-include of glib.h which seems to have slipped into daemon/mount.c while at it.)
Comment 7 Christian Kellner 2009-10-09 20:37:38 UTC 

*** This bug has been marked as a duplicate of bug 563788 ***