GNOME Bugzilla – Bug 561312
open this recurring instance or series
Last modified: 2013-09-13 00:58:10 UTC
We should ask the user whether he wants to open that instance or the series while opening recurring appointments. We ask whether user wants to modify this instance or series later while modifying. To make changes to a recurring instance and applying it to the series would be buggy and needs to be handled properly in all backends. It would be better to ask it while opening the recurring event rather than after modifying it.
Without having this dialog while opening the editor, just cleaned up the code to sanitize the master event while modifying all instances. The recurrence dialog will be shown only for master events and not for detached instances. The handling of dates while modifying a recurring appointment has been removed at the backend as its handled in evo side.
Created attachment 130320 [details] [review] evo side fix
Created attachment 130321 [details] [review] eds part of it
Ouch, I had some comments on these, which got lost :( If I recall correctly, it was something like: a) wasn't the main advantage of this bug to ask users to what edit at the beginning, not at the end? b) I copied some similar code from eds to some other backend too c) in evo patch, taking the pattern of your changes, not all related code has been changed. (I had line numbers, but it gone) :( Feel free to commit to trunk after branch for 2.26.0, but please try to look into those (vaguely described) things above. Thanks.
For a) Since we don have a viewer/editor as a separate entities, the users who try to view the contents of the appointment may feel bad if they see a dialog coming up. So i avoided that to ask the users what to edit at the end. b) Yes, this code remains in some backends and it would be better to handle in evo code. Have slightly modified it. The code at the backends needs to be removed. c) I covered up editing through compEditor, day view and week view. Anything else missing?
ad a) I see, though for editing I believe it is better to ask before, instead of trying to recover master object and propagate some particular changes to it instead of working with the master instance since the beginning. I really saw this as a good idea. ad c) I searched for calls of recur_component_dialog and the way you modified functions above and below it, and most of them follow the pattern, except of: calendar/gui/e-cal-model-calendar.c:366: calendar/gui/dialogs/comp-editor.c:1911:
Chen, this seems to be committed in sources already. Is it?
Oh sorry. Changing the status.
the change fixes recurrent event editing mostly as described on bug #580724 but the first event is not updated correctly when changing the recurrent day ...
Hm. So do we keep this bug open as there seem to be issues in comment #6 or do we close it?
Oh this can be closed. Closing it. Should have done it before once Milan pointed in irc.