GNOME Bugzilla – Bug 561223
Cleaning up GTK Includes in gdm
Last modified: 2009-07-16 18:07:11 UTC
I'm working on implementing http://live.gnome.org/GnomeGoals/CleanupGTKIncludes If it's not a good idea, or not currently on the agenda, please let me know. Otherwise I'll be working on this for now.
Created attachment 122855 [details] [review] patch for this bug
ping.
Looks fine but the copy/pasted libnotification area code should be fixed in the original first if it hasn't already been.
Jon: There's a ticket and patch about it at http://trac.galago-project.org/ticket/172
Can we get this committed now, Jon ?
ping...
Please, commit! Thanks for the effort and patience here.
It seems that the patch was already commited. However gui/user-switch-applet/gdm-user-menu-item.h has still a reference to <gtk/gtkimagemenuitem.h>. However, this file isn't referenced anywere, not even in a Makefile.am. Moreover, the corresponding gdm-user-menu-item.c isn't compiled either, it only appears in po files. I don't know GDM codebase, so there's 2 possibilities: 1. gdm-user-menu-item is a new object, so the '.c' file should be fixed to use the corresponding header, and the header should be fixed with respect to the current bug 2. gdm-user-menu-item is an old object, and is not required anymore. It should then be removed from the repository, and the corresponding .po files fixed.
Looks like it was replaced by gdm-entry-menu-item and never got removed from version control.
(In reply to comment #9) > Looks like it was replaced by gdm-entry-menu-item and never got removed from > version control. So what about cleaning up if it's totally unused?
gone.