After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560482 - g_set_error accept 0 as domain, which is inconsistent with g_error_new*/g_set_error_literal
g_set_error accept 0 as domain, which is inconsistent with g_error_new*/g_se...
Status: RESOLVED WONTFIX
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-11-12 11:20 UTC by Christian Persch
Modified: 2008-11-28 20:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (300 bytes, patch)
2008-11-12 11:22 UTC, Christian Persch 		none Details | Review

Description Christian Persch 2008-11-12 11:20:42 UTC 
g_error_new[_literal] and g_set_error_literal (by using g_error_new_literal) don't accept 0 as error domain; but g_set_error does accept 0 since it doesn't g_return_if_fail() on that, and uses g_new_error_valist internally which doesn't do so either.

Since unfortunately g_set_error (error, 0, ...) has a few hits on google codesearch, fixing this may need to be deferred to glib 3, or be WONTFIXed.
Comment 1 Christian Persch 2008-11-12 11:22:47 UTC 
Created attachment 122482 [details] [review]
patch
Comment 2 Matthias Clasen 2008-11-28 20:53:40 UTC 
lets go with WONTFIX