GNOME Bugzilla – Bug 560466
Improve the accuracy of label guess for Firefox 3
Last modified: 2008-11-17 22:34:02 UTC
Orca's label guess functionality should: 1. Not guess form fields as "labels" for other form fields. 2. Handle "labels" which are composed of multiple objects such as text which contains links (Orca does this already for items on the same line, but not for items on different lines). 3. Use the strings already obtained for the next/previous line. 4. Better handle "labels" which are graphics with alt text in a table/grid.
Created attachment 122474 [details] [review] revision 1 Pylinted and regression tested with updated regression tests to remove 'BUG?'s. This also gives us a slight performance improvement (not much, but every little bit helps....): Bugzilla Advanced Search: ncalls tottime percall cumtime percall 50 0.026 0.001 9.593 0.192 guessTheLabel-before 48 0.029 0.001 6.723 0.140 guessTheLabel-after Entries regression test: ncalls tottime percall cumtime percall 39 0.027 0.001 6.472 0.166 guessTheLabel-before 39 0.029 0.001 4.760 0.122 guessTheLabel-after Mike, please test. Thanks!
*** Bug 517759 has been marked as a duplicate of this bug. ***
So far this one looks good. I'd be in favor of getting it in trunk for wider testing.
Thanks Mike. Patch committed to trunk. Moving to pending.
I have been doing quite a bit of testing with this patch. It seems to work well. Joanie thought it might be impacting another problem I was having but it is not so I think it is good.
Thanks Mike. What's the verdict on branch? Commit or not?
Were it me I think I'd add it to the branch as well.
Okie dokie. Patch committed to the gnome-2-24 branch. Closing as FIXED.