After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560439 - GNOME Goal: Remove deprecated GLib symbols
GNOME Goal: Remove deprecated GLib symbols
Status: RESOLVED FIXED
Product: gnome-speech
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Willie Walker
GNOME Speech Maintainer(s)
Depends on:
Blocks: 560423
 
 
Reported: 2008-11-12 02:39 UTC by Luis Menina
Modified: 2009-02-10 13:18 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Patch (862 bytes, patch)
2009-02-08 16:23 UTC, Willie Walker 		committed Details | Review

Description Luis Menina 2008-11-12 02:39:34 UTC 
See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib
Here are the files+lines using deprecated GLib symbols in this module:

gnome-speech/gnome-speech/speaker.c:107:		if (!g_strcasecmp (name, p->name))
gnome-speech/drivers/eloquence/eloquencespeaker.c:387:		if (!g_strcasecmp (voice_spec->name, name))
Comment 1 Willie Walker 2008-12-02 15:54:53 UTC 
Thanks!  (In reply to comment #0)
> See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib

Thanks!  This URL says "Most of the work will consist in replacing g_strncasecmp and g_strcasecmp with the right string comparison function."  Do you have a list of choices we might make for the the "right string comparison function"?  It also might be nice to update the WIKI to include a list of these.
Comment 2 Thomas Andersen 2009-02-06 02:33:23 UTC 
See http://library.gnome.org/devel/glib/stable/glib-String-Utility-Functions.html#g-strncasecmp for advice on what functions to use instead
Comment 3 Willie Walker 2009-02-08 16:23:19 UTC 
Created attachment 128235 [details] [review]
Patch

Thanks for the tip/advice.  Patch committed to trunk.
Comment 4 André Klapper 2009-02-08 23:58:14 UTC 
Thanks guys! I've updated the wikipage.
Comment 5 Thomas Andersen 2009-02-10 12:59:46 UTC 
I am not seeing this patch in trunk. But perhaps you are using git-svn or something and will do the final commit to server later?
Comment 6 Willie Walker 2009-02-10 13:18:26 UTC 
(In reply to comment #5)
> I am not seeing this patch in trunk. But perhaps you are using git-svn or
> something and will do the final commit to server later? 

Yikes.  Thanks.  Resolved/committed now.  For real.