After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560377 - support new running async output record in GDB trunk (6.8.50.20081111)
support new running async output record in GDB trunk (6.8.50.20081111)
Status: RESOLVED FIXED
Product: nemiver
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Dodji Seketeli
Nemiver maintainers
Depends on:
Blocks: 560235
 
 
Reported: 2008-11-11 16:55 UTC by Dodji Seketeli
Modified: 2008-11-13 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
candidate fix (9.97 KB, patch)
2008-11-11 16:59 UTC, Dodji Seketeli 		accepted-commit_now Details | Review

Description Dodji Seketeli 2008-11-11 16:55:03 UTC 
When the GDB/MI command -exec-continue is used, MI sends a new out-of-band record that has the form:
*running,thread-id="<thread-id>".

We need to support that, otherwise nemiver hangs.
Comment 1 Dodji Seketeli 2008-11-11 16:59:03 UTC 
Created attachment 122432 [details] [review]
candidate fix

This patch adds the said functionality and passes make check.
Comment 2 Jonathon Jongsma 2008-11-12 03:22:05 UTC 
Only a couple minor comments:

cur += 9; 
should probably be 
cur += strlen(PREFIX_STOPPED_ASYNC_OUTPUT);
(in a couple places)

I'm not a fan of LOG_PARSING_ERROR2.  The name doesn't say anything about what's different about it.  Something like LOG_PARSING_ERROR_MSG might be slightly nicer.

Otherwise it seems fine, though I haven't tested it since I'm not running GDB Trunk ;)
Comment 3 Dodji Seketeli 2008-11-13 13:14:53 UTC 
Thanks for the comments.

I have updated the patch and pushed to trunk, in changeset #944.